Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1528781
| Summary: | Review Request: mpfr - multiple-precision floating-point computations [needs sponsor] | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | James Paul Turner <jamesturner246> |
| Component: | Package Review | Assignee: | Pavel Cahyna <pcahyna> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jamesturner246, package-review, pcahyna |
| Target Milestone: | --- | Flags: | pcahyna:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-03-06 18:53:04 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 177841 | ||
|
Description
James Paul Turner
2017-12-24 01:10:38 UTC
https://fedoraproject.org/wiki/Policy_for_nonresponsive_package_maintainers http://bugz.fedoraproject.org/mpfr > Summary: A C library for multiple-precision floating-point computations The leading "A C" is a example of a summary where the leading article is superfluous and reduces readability. https://fedoraproject.org/wiki/Examples_of_good_package_summaries > BuildRequires: autoconf libtool gmp-devel Requiring gmp-devel is a hint that it links with libgmp somehow. > Requires: gmp >= 4.2.3 https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires > Requires(post): /sbin/ldconfig > Requires(postun): /sbin/ldconfig With the scriptlets running /sbin/ldconfig directly, there are automatic dependencies on /sbin/ldconfig. > %package devel > Requires: %{name} = %{version}-%{release} https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > Requires(post): /sbin/install-info > Requires(preun): /sbin/install-info Also see the %post and %preun sections. There are official scripts for a long time: https://fedoraproject.org/wiki/Packaging:Scriptlets#Texinfo > If you want to develop applications which will use the MPFR library, > you'll need to install the mpfr-devel package. You'll also need to > install the mpfr package. Redundant instructions. mpfr is installed automatically due to dependencies. Michael. Thank you for your feedback. I have initiated the unresponsive packager procedure: https://bugzilla.redhat.com/show_bug.cgi?id=1529827 I have also made changes to the specfile which hopefully fix the previous issues. Furthermore, I have also updated MPFR to the just-released version 4.0.0. Specfile: https://jamesturner246.fedorapeople.org/mpfr-4.0.0/mpfr.spec SRPM: https://jamesturner246.fedorapeople.org/mpfr-4.0.0/mpfr-4.0.0-1.fc28.src.rpm Do respond if any issues remain - it is appreciated. All the best, James. I forgot the Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23945790 There is an API change in MPFR 4, see http://www.mpfr.org/mpfr-current/#changes (also its soname changes to libmpfr.so.6). Given that quite a lot of packages depend on mpfr, are they ready to cope with this API change? See https://fedoraproject.org/wiki/Changes/mpfr-4.0.0 and https://pagure.io/releng/issue/7247 I looked at how the Ruby_2.5 folks were handling things, and they seemed to have a nice plan. The packages can be rebuilt and tested in a separate Koji tag, such that, if there are any problems, the tag can simply be deleted without merging. I will test and take care of the possible reintroduction of https://bugzilla.redhat.com/show_bug.cgi?id=515958 once we have the tag. *** This bug has been marked as a duplicate of bug 1537252 *** |