Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1543806

Summary:	kexec-tools: Build everything except purgatory with Fedora build flags
Product:	[Fedora] Fedora	Reporter:	Florian Weimer <fweimer>
Component:	kexec-tools	Assignee:	Kairui Song <kasong>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	28	CC:	bhe, fweimer, igor.raits, kasong, ruyang
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-02-25 02:45:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1539083

Description Florian Weimer 2018-02-09 11:13:17 UTC

kexec-tools-2.0.16-4.fc28 builds /sbin/kdump, /sbin/kexec, /sbin/makedumpfile, /sbin/vmcore-dmesg with the full complement of Fedora build flags.  This is probably due to

%undefine _hardened_build

in the RPM spec file.

More information about RPM macros to set CFLAGS and LDFLAGS is available here:

https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md

If these flags insufficient, please let me know.  I'll try to add something that fits your use case.

Comment 1 Fedora End Of Life 2018-02-20 15:32:10 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 2 Dave Young 2018-04-28 06:02:23 UTC

I'm not sure how to fix the old bug without the %undefine _hardened_build, seems it is the only way.  Appreciated if you have better idea, I'm glad to do some experiment.

The original bug is:
https://bugzilla.redhat.com/show_bug.cgi?id=1236456

Comment 3 Igor Raits 2018-07-21 07:39:32 UTC

ping?

Comment 4 Florian Weimer 2018-07-23 11:29:39 UTC

(In reply to Dave Young from comment #2)
> I'm not sure how to fix the old bug without the %undefine _hardened_build,
> seems it is the only way.  Appreciated if you have better idea, I'm glad to
> do some experiment.
> 
> The original bug is:
> https://bugzilla.redhat.com/show_bug.cgi?id=1236456

That's why I said everything *except* purgatory.  Do you need help with implementing that?

Comment 5 Dave Young 2018-07-24 01:54:14 UTC

(In reply to Florian Weimer from comment #4)
> (In reply to Dave Young from comment #2)
> > I'm not sure how to fix the old bug without the %undefine _hardened_build,
> > seems it is the only way.  Appreciated if you have better idea, I'm glad to
> > do some experiment.
> > 
> > The original bug is:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1236456
> 
> That's why I said everything *except* purgatory.  Do you need help with
> implementing that?

Florian, yes, if you can provide a patch, it would be helpful.

Comment 6 Kairui Song 2019-02-25 02:45:42 UTC

Fixed in 2.0.18-5:

annocheck kexec-tools-2.0.18-5.fc30.x86_64.rpm
Hardened: eppic_makedumpfile.so: PASS.
Hardened: makedumpfile: PASS.
Hardened: kexec: PASS.
Hardened: vmcore-dmesg: PASS.