Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1548551

Summary: ledmon: Partial application of Fedora build flags
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: ledmonAssignee: Michal Sekletar <msekleta>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: jsynacek, msekleta
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ledmon-0.80-6.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-26 14:48:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1539083    

Description Florian Weimer 2018-02-23 20:19:24 UTC
/usr/sbin/ledctl and /usr/sbin/ledmon in ledmon-0.80-5.fc28.x86_64 have not been linked with the standard Fedora linker flags (LDFLAGS) from redhat-rpm-config.

There doesn't seem to be any LDFLAGS injection at all.

cc  -lsgutils2 /builddir/build/BUILD/ledmon-0.80/src/_build/ledmon.o /builddir/build/BUILD/ledmon-0.80/src/_build/pidfile.o /builddir/build/BUILD/ledmon-0.80/src/_build/ahci.o /builddir/build/BUILD/ledmon-0.80/src/_build/block.o /builddir/build/BUILD/ledmon-0.80/src/_build/cntrl.o /builddir/build/BUILD/ledmon-0.80/src/_build/enclosure.o /builddir/build/BUILD/ledmon-0.80/src/_build/list.o /builddir/build/BUILD/ledmon-0.80/src/_build/raid.o /builddir/build/BUILD/ledmon-0.80/src/_build/scsi.o /builddir/build/BUILD/ledmon-0.80/src/_build/slave.o /builddir/build/BUILD/ledmon-0.80/src/_build/status.o /builddir/build/BUILD/ledmon-0.80/src/_build/sysfs.o /builddir/build/BUILD/ledmon-0.80/src/_build/smp.o /builddir/build/BUILD/ledmon-0.80/src/_build/dellssd.o /builddir/build/BUILD/ledmon-0.80/src/_build/utils.o /builddir/build/BUILD/ledmon-0.80/src/_build/pci_slot.o /builddir/build/BUILD/ledmon-0.80/src/_build/vmdssd.o -o ledmon

ledmon_cflags.patch probably needs updating to deal with LDFLAGS as well.

See https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md for information on RPM macros and environment variables provided by the build environment.