Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1556132
| Summary: | ppp: FTBFS in F28; DES code needs to be ported to OpenSSL | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fedora Release Engineering <releng> | ||||||
| Component: | ppp | Assignee: | Jaroslav Škarvada <jskarvad> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 28 | CC: | awilliam, fweimer, jaskalnik, jskarvad, jsynacek, msekleta, rbarlow, robatino, thozza | ||||||
| Target Milestone: | --- | Keywords: | Reopened | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | AcceptedBlocker | ||||||||
| Fixed In Version: | ppp-2.4.7-18.fc29 ppp-2.4.7-18.fc28 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2018-04-04 15:51:31 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1469206, 1537261, 1555378 | ||||||||
| Attachments: |
|
||||||||
|
Description
Fedora Release Engineering
2018-03-14 23:17:27 UTC
FESCo has declared this to be a F28 final blocker. Is anyone working on the port? (In reply to Florian Weimer from comment #2) > Is anyone working on the port? I will take it. It seems the libxcrypt is nogo, thus we need to use openssl. There is already alternative openssl code in the pppcrypt.c, but unfortunately it seems unmaintained and for ancient openssl version. I will try to rewrite it for recent openssl during tomorrow (2018-03-27). It shouldn't be hard. per #c1 . Randy, note for the future: marking it as Blocks: FinalBlocker only marks it as a *proposed* blocker, to mark it as *accepted*, you also need the whiteboard field. (In reply to Adam Williamson from comment #4) > per #c1 . Randy, note for the future: marking it as Blocks: FinalBlocker > only marks it as a *proposed* blocker, to mark it as *accepted*, you also > need the whiteboard field. Thanks for the note! Created attachment 1413742 [details]
Proposed fix
Created attachment 1413756 [details]
Unit test
This is very simple unit test I used inline with hardcoded randomly generated plain text and key (I used several plain texts and keys, the following is result for the plain text and key which is currently hardcoded in the attachement).
Fedora 26 with libcrypt / glibc:
11b4ec5ab7bdb881
c060b3a810ef79fb
11b4ec5ab7bdb881
Fedora 29/rawhide with openssl:
11b4ec5ab7bdb881
c060b3a810ef79fb
11b4ec5ab7bdb881
The meaning:
plain text in hex
encrypted data in hex
decrypted plain text in hex
Of course the test could be polished, but it should be sufficient for the purpose of this bugzilla.
Upstream ticket: https://github.com/paulusmack/ppp/issues/93 Would you please put the fix into Fedora 28 as well? You will have to file a Bodhi update for this. (In reply to Florian Weimer from comment #9) > Would you please put the fix into Fedora 28 as well? You will have to file > a Bodhi update for this. Ah no problem, I missed the 28 request :) (In reply to Jaroslav Škarvada from comment #10) > (In reply to Florian Weimer from comment #9) > > Would you please put the fix into Fedora 28 as well? You will have to file > > a Bodhi update for this. > > Ah no problem, I missed the 28 request :) In the meantime it has been already built by besser82: https://koji.fedoraproject.org/koji/buildinfo?buildID=1063009 ppp-2.4.7-18.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-b709c38412 Re-opening, as the bug was filed on 28. ppp-2.4.7-18.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-b709c38412 ppp-2.4.7-18.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |