Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1569411

Summary: When installing Fedora to dual boot with Windows, Anaconda does not add GRUB entry for Windows.
Product: [Fedora] Fedora Reporter: Lukas Ruzicka <lruzicka>
Component: grub2Assignee: Peter Jones <pjones>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 28CC: anaconda-maint-list, awilliam, fzatlouk, jonathan, kellin, kparal, lkundrak, lruzicka, pjones, robatino, sgallagh, vanmeeuwen+fedora, v.podzimek+fedora, vponcova, wwoods
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard: AcceptedBlocker
Fixed In Version: grub2-2.02-34.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-25 13:29:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1469206    

Description Lukas Ruzicka 2018-04-19 08:57:44 UTC
Description of problem:

Anaconda does not create a GRUB entry for Windows when installing Fedora to dualboot. 

Version-Release number of selected component (if applicable):

anaconda-28.22.7-1

How reproducible:

Always

Steps to Reproduce:
1. Install Windows to /dev/sda
2. Use gparted to resize the ntfs partition or let Anaconda do it
3. Install Fedora, either from Live CD or from netinst (the behaviour is the same)
4. After the installation is complete, reboot.
5. Check the Grub entries.

Actual results:

Anaconda does not create a Windows entry

Expected results:

Windows entry is created and able to boot.

Additional info:

We were able to find a following workaround:
1. Boot the installed Fedora.
2. Install os-prober (dnf install os-prober)
3. Regenerete Grub confing (grub2-mkconfig -o /etc/grub2.cfg)
4. Reboot and see that the entry has been added.

This behaviour and workaround is the same for EFI systems as well.

Comment 1 Fedora Blocker Bugs Application 2018-04-19 09:02:58 UTC
Proposed as a Blocker for 28-final by Fedora user lruzicka using the blocker tracking app because:

 This behaviour breaks the release criteria "The installer must be able to install into free space alongside an existing clean Windows installation and install a bootloader which can boot into both Windows and Fedora. " because it does not allow booting into Windows.
Therefore I am proposing this as a blocker.

Comment 2 Kamil Páral 2018-04-19 12:04:16 UTC
On Fedora 27, grub2-tools requires os-prober:

$ sudo dnf repoquery --whatrequires os-prober
Last metadata expiration check: 0:22:53 ago on Thu 19 Apr 2018 01:28:52 PM CEST.
calamares-0:3.1.1-1.fc27.x86_64
calamares-0:3.1.8-2.fc27.x86_64
grub2-tools-1:2.02-18.fc27.x86_64
grub2-tools-1:2.02-22.fc27.x86_64
grub2-tools-efi-1:2.02-18.fc27.x86_64
grub2-tools-efi-1:2.02-22.fc27.x86_64
grub2-tools-extra-1:2.02-18.fc27.x86_64
grub2-tools-extra-1:2.02-22.fc27.x86_64

On Fedora 28, it doesn't:
$ sudo dnf repoquery --whatrequires os-prober
calamares-0:3.1.8-8.fc28.x86_64


os-prober dependency has been removed from grub2-tools in this commit:
https://src.fedoraproject.org/rpms/grub2/c/78e1a10
The commit message doesn't say why.

Reassigning to grub2. Peter, can you confirm whether this was intentional or a mistake? Is anaconda supposed to carry the dependency itself now?

Comment 3 Adam Williamson 2018-04-19 19:41:14 UTC
+1 blocker, per the criteria.

Comment 4 Stephen Gallagher 2018-04-20 14:32:02 UTC
+1 blocker

Comment 5 Kamil Páral 2018-04-20 14:43:10 UTC
+1 blocker, making it an accepted blocker

Comment 6 Adam Williamson 2018-04-23 16:01:47 UTC
ping pjones - can you please do a build and update for this? go/no-go is Thursday, we're getting tight on time. Thanks!

Comment 7 Fedora Update System 2018-04-23 19:48:51 UTC
grub2-2.02-34.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-6d40d4db1f

Comment 8 František Zatloukal 2018-04-24 14:41:12 UTC
Issue seems fixed in grub2-2.02-34.fc28.

(Tested by grub2-mkconfig on live /w updated grub packages). Looks like we'll need new compose to verify fix in Anaconda/installed system.

Comment 9 Fedora Update System 2018-04-24 19:13:53 UTC
grub2-2.02-34.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-6d40d4db1f

Comment 10 Fedora Update System 2018-04-25 00:03:10 UTC
grub2-2.02-34.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Kamil Páral 2018-04-25 08:28:41 UTC
Need to get this confirmed with a new compose.

Comment 12 František Zatloukal 2018-04-25 13:29:20 UTC
It's working fine on RC1.1