Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1578708

Summary: bacula: Partial Fedora build flags injection
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: baculaAssignee: Simone Caronni <negativo17>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 28CC: andreas, jridky, negativo17, phracek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: bacula-9.2.1-1.fc27 bacula-9.2.1-1.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-09-22 19:45:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1539083    

Description Florian Weimer 2018-05-16 08:40:19 UTC 
/usr/sbin/bat in bacula-console-bat-9.0.7-3.fc28.x86_64 has not been linked with the standard Fedora linker flags (LDFLAGS) in redhat-rpm-config.  Specifically, it is not PIE/a full ASLR executable, and the BIND_NOW flag is not used.

The libtool invocation looks like this:

/builddir/build/BUILD/bacula-9.0.7/libtool --silent --tag=CXX --mode=link g++ -Wl,-O1 -o bat obj/main.o obj/bat_conf.o obj/mainwin.o obj/qstd.o obj/pages.o obj/dircomm.o obj/dircomm_auth.o obj/console.o obj/prerestore.o obj/restore.o obj/brestore.o obj/label.o obj/relabel.o obj/mount.o obj/run.o obj/runcmd.o obj/estimate.o obj/prune.o obj/select.o obj/textinput.o obj/medialist.o obj/mediaview.o obj/mediaedit.o obj/joblist.o obj/clients.o obj/storage.o obj/content.o obj/fileset.o obj/joblog.o obj/job.o obj/jobs.o obj/restoretree.o obj/help.o obj/mediainfo.o obj/dirstat.o obj/clientstat.o obj/storstat.o obj/fmtwidgetitem.o obj/comboutil.o obj/qrc_main.o obj/moc_mainwin.o obj/moc_pages.o obj/moc_dircomm.o obj/moc_console.o obj/moc_restore.o obj/moc_label.o obj/moc_relabel.o obj/moc_mount.o obj/moc_run.o obj/moc_select.o obj/moc_textinput.o obj/moc_medialist.o obj/moc_mediaview.o obj/moc_mediaedit.o obj/moc_joblist.o obj/moc_clients.o obj/moc_storage.o obj/moc_content.o obj/moc_fileset.o obj/moc_joblog.o obj/moc_job.o obj/moc_jobs.o obj/moc_restoretree.o obj/moc_help.o obj/moc_mediainfo.o obj/moc_dirstat.o obj/moc_clientstat.o obj/moc_storstat.o   -L../lib -lbaccfg -lbac -L../findlib -lbacfind -lssl -lcrypto -lQt5Widgets -lQt5Gui -lQt5Core -lGL -lpthread 

Since all flags from LDFLAGS are missing, this looks more like a Bacula-specific makefile problem then the generic libtool issue.
Comment 1 Simone Caronni 2018-05-16 12:06:13 UTC 
Sigh. Upstream has a very specific point ov view in terms of binaries, location and compiler flags.
Comment 2 Simone Caronni 2018-08-21 07:52:34 UTC 
Seems to be fixed in 9.2.1, I see the LDFLAGS passed down:

https://kojipkgs.fedoraproject.org//packages/bacula/9.2.1/1.fc28/data/logs/x86_64/build.log
Comment 3 Fedora Update System 2018-08-21 08:33:12 UTC 
bacula-9.2.1-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-b834dc45b0
Comment 4 Fedora Update System 2018-08-21 08:33:27 UTC 
bacula-9.2.1-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-304169b221
Comment 5 Fedora Update System 2018-08-22 00:33:54 UTC 
bacula-9.2.1-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-304169b221
Comment 6 Fedora Update System 2018-08-22 03:13:40 UTC 
bacula-9.2.1-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-b834dc45b0
Comment 7 Fedora Update System 2018-09-22 19:45:41 UTC 
bacula-9.2.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
Comment 8 Fedora Update System 2018-09-22 20:50:14 UTC 
bacula-9.2.1-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.