Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1594647
Summary: | npm Error: Cannot find module 'are-we-there-yet' | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dan Callaghan <dcallagh> |
Component: | nodejs | Assignee: | NodeJS Packaging SIG <nodejs-sig> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | athmanem, chemobejk, jamielinux, jman012345, jsmith.fedora, manisandro, mrunge, nodejs-sig, sgallagh, tchollingsworth, thrcka, zsvetlik |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | nodejs-10-20180720171652.9c690d0e | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-08-08 16:44:40 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1604516, 1604996, 1637701 |
Description
Dan Callaghan
2018-06-25 05:41:49 UTC
FYI Koschei told me about this: https://apps.fedoraproject.org/koschei/package/nodejs-normalize-path?collection=f29 https://kojipkgs.fedoraproject.org/work/tasks/9553/27789553/build.log I expect it broke a lot of (all?) nodejs packages. *** Bug 1596912 has been marked as a duplicate of this bug. *** I've been looking into this today. What happened is that npm flattened its bundling structure such that all of its dependencies are stored at the top of its node_module hierarchy, rather than having each dependency bundle their own underneath. On the one hand, this is good as it means that there's less risk of carrying differing versions throughout the project. On the other hand, it causes import issues if the directories are symlinked. There's an argument to the node application to work around this, --preserve-symlinks, but a search of the web implies that this may introduce a bunch of risky edge-cases, so we don't want to do that. The most direct solution would be to abandon any hope of ever debundling NPM and ridding ourselves of the symlinked directories. This would require following https://fedoraproject.org/wiki/Packaging:Directory_Replacement#Scriptlet_to_replace_a_symlink_to_a_directory_with_a_directory for all of the (many) symlinked directories in Node.js I'm going to be away on PTO this coming week, so if someone else wants to pick up from where I've left off, I'd appreciate it. I've got a fix for this coming along. It will be part of the 10.7.0 release I'll have out later tonight. Sorry this has dragged on for so long. 10.7.0-2.fc29.1 seems broken: Problem 1: cannot install the best update candidate for package npm-1:6.1.0-1.10.5.0.1.fc29.x86_64 - nothing provides nodejs = 1:10.7.0-2.fc29 needed by npm-1:6.1.0-1.10.7.0.2.fc29.1.x86_64 Problem 2: problem with installed package npm-1:6.1.0-1.10.5.0.1.fc29.x86_64 - package npm-1:6.1.0-1.10.5.0.1.fc29.x86_64 requires nodejs = 1:10.5.0-1.fc29, but none of the providers can be installed - nodejs-1:10.5.0-1.fc29.i686 has inferior architecture - cannot install both nodejs-1:10.7.0-2.fc29.1.x86_64 and nodejs-1:10.5.0-1.fc29.x86_64 - cannot install the best update candidate for package nodejs-1:10.5.0-1.fc29.x86_64 - nothing provides nodejs = 1:10.7.0-2.fc29 needed by npm-1:6.1.0-1.10.7.0.2.fc29.1.x86_64 (try to add '--allowerasing' to command line to replace conflicting packages or '--skip-broken' to skip uninstallable packages) Looks like the requires in npm is missing the .1 at the end: Requires: nodejs = %{epoch}:%{nodejs_version}-%{nodejs_release}%{?dist}.1 ^^ (In reply to Sandro Mani from comment #5) > 10.7.0-2.fc29.1 seems broken: > > Problem 1: cannot install the best update candidate for package > npm-1:6.1.0-1.10.5.0.1.fc29.x86_64 > - nothing provides nodejs = 1:10.7.0-2.fc29 needed by > npm-1:6.1.0-1.10.7.0.2.fc29.1.x86_64 > Problem 2: problem with installed package npm-1:6.1.0-1.10.5.0.1.fc29.x86_64 > - package npm-1:6.1.0-1.10.5.0.1.fc29.x86_64 requires nodejs = > 1:10.5.0-1.fc29, but none of the providers can be installed > - nodejs-1:10.5.0-1.fc29.i686 has inferior architecture > - cannot install both nodejs-1:10.7.0-2.fc29.1.x86_64 and > nodejs-1:10.5.0-1.fc29.x86_64 > - cannot install the best update candidate for package > nodejs-1:10.5.0-1.fc29.x86_64 > - nothing provides nodejs = 1:10.7.0-2.fc29 needed by > npm-1:6.1.0-1.10.7.0.2.fc29.1.x86_64 > (try to add '--allowerasing' to command line to replace conflicting packages > or '--skip-broken' to skip uninstallable packages) > > Looks like the requires in npm is missing the .1 at the end: > > Requires: nodejs = %{epoch}:%{nodejs_version}-%{nodejs_release}%{?dist}.1 > ^^ yeah, that .1 is a mistake. I removed it at least once and then a bad merge from the "10" branch brought it back again. *sigh* I'll fix that today when I build -3 to fix an annobin issue as well. FWIW, the module stream version shouldn't have this problem, so if you want to test with that, install fedora-repos-modular and do `dnf module install nodejs:10` *** Bug 1584732 has been marked as a duplicate of this bug. *** nodejs-10-20180720171652.9c690d0e has been submitted as an update to Fedora 28 Modular. https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2018-4058b2f0fb This *should* be fixed in Rawhide at this point (and fixes for the Modular repo are in the queue). Please confirm. Working fine as far as I can see here, thanks. nodejs-10-20180720171652.9c690d0e has been pushed to the Fedora 28 Modular testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2018-4058b2f0fb nodejs-10-20180720171652.9c690d0e has been pushed to the Fedora 28 Modular stable repository. If problems still persist, please make note of it in this bug report. |