Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1632851
Summary: | Review Request: Pencil2D - create animation using both bitmap and vector graphics | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Luis Segundo <luis> |
Component: | Package Review | Assignee: | Luis Bazan <bazanluis20> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | bazanluis20, echevemaster, package-review |
Target Milestone: | --- | Flags: | bazanluis20:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-10-19 18:23:15 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 177841 |
Description
Luis Segundo
2018-09-25 17:03:16 UTC
I'll take this one (In reply to Eduardo Echeverria from comment #2) > I'll take this one Thanks! Regards! Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: make See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in pencil2d See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. Please, Luis. process the comments from Luis, and make at least a revision to a packager or candidate to packager. Thanks guys. I'm going to work on the issues the files has been updated. Can you see below the koji Results https://koji.fedoraproject.org/koji/taskinfo?taskID=30153857 +1 approved! Thanks Eduardo for the sponsor +1 Cheers, (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/Pencil2D Pencil2D-0.6.2-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f76e2a5e24 Pencil2D-0.6.2-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-223ebd7b50 Pencil2D-0.6.2-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-223ebd7b50 Pencil2D-0.6.2-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f76e2a5e24 Pencil2D-0.6.2-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. Pencil2D-0.6.2-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. I just wanted to add a note that this probably shouldn't have passed review, as it builds as a noarch package but it sure compiles a bunch of C++ and the installed binary looks rather arch-specific: pencil2d: ELF 64-bit LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=a662722fec0e98e3f674072523cbe982acd5842b, for GNU/Linux 3.2.0, not stripped, too many notes (256) Looking at some of the koji builds linked here, it does look like the package was archful at some point in time. But the initial import of the spec had BuildArch: noarch, as does the spec linked in the first comment. I will of course file a bug but wanted to leave a note in the review ticket as well. Pencil2D-0.6.3-2.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ef4b7c5bef Pencil2D-0.6.3-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-e671f6ea79 Pencil2D-0.6.3-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-a13724dd77 Pencil2D-0.6.3-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ef4b7c5bef Pencil2D-0.6.3-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-a13724dd77 Pencil2D-0.6.3-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-e671f6ea79 Pencil2D-0.6.3-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. Pencil2D-0.6.3-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. Pencil2D-0.6.3-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |