Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1642729
Summary: | vlc crashes when trying to open Universal Plug'n'Play stream | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jonathan Dieter <jdieter> | ||||||||
Component: | libupnp | Assignee: | Nicolas Chauvet (kwizart) <kwizart> | ||||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
Severity: | unspecified | Docs Contact: | |||||||||
Priority: | unspecified | ||||||||||
Version: | 29 | CC: | ajax, jfd, kwizart, negativo17, vihilantes | ||||||||
Target Milestone: | --- | ||||||||||
Target Release: | --- | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | libupnp-1.8.4-1.fc29 | Doc Type: | If docs needed, set a value | ||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2019-01-13 02:31:10 UTC | Type: | Bug | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Attachments: |
|
I don't reproduce with vlc from rpmfusion and kodi (both on f29). I confirm that I can browse upnp and mDNS content Can you submit a stacktrace ? Created attachment 1497542 [details]
core_backtrace
Here's core_backtrace from abrt. I could also submit the coredump, but I'd rather send that to you directly as it has personal data in it.
Created attachment 1498108 [details] Return pointer rather than pointer to pointer Ok, I spent a couple of hours on this this evening and I've tracked it down to this: in ssdp_ctrlpt.c, we return the address of param to the callback, but param is already a pointer. Returning param rather than the address of param fixes the crashes on my system. I've build an updated rpm with this patch at: https://www.jdieter.net/downloads/libupnp-1.8.3-4.fc29.src.rpm FWIW, I've just looked at the code in 1.6.25 (the older version of libupnp), and param is allocated off the stack there rather than being a pointer, so this looks like someone forgot to change how the callback is called. /me is back from vacation @Jonathan Can you forward this upstream directly if not done already ? Thx @kwizart, I'm happy to report this, but where exactly *is* upstream? https://sourceforge.net/p/pupnp/bugs doesn't look very promising. Is there a better place to file this? I think that the sourceforge.net project is still more or less monitored, but the center of libupnp activity is currently https://github.com/mrjimenez/pupnp (In reply to Jean-Francois Dockes from comment #7) > I think that the sourceforge.net project is still more or less monitored, > but the center of libupnp activity is currently > https://github.com/mrjimenez/pupnp Thanks for pointing me to this. Apparently this was fixed upstream in August and the patch is in 1.8.4, which was released at the end of October. Nicolas, is there any chance we could get an update to 1.8.4? ...
> Thanks for pointing me to this. Apparently this was fixed upstream in
> August and the patch is in 1.8.4, which was released at the end of October.
> Nicolas, is there any chance we could get an update to 1.8.4?
Please apply to co-maintainer, I'm not using upnp at all myself
(In reply to Nicolas Chauvet (kwizart) from comment #9) > ... > > Thanks for pointing me to this. Apparently this was fixed upstream in > > August and the patch is in 1.8.4, which was released at the end of October. > > Nicolas, is there any chance we could get an update to 1.8.4? > > Please apply to co-maintainer, I'm not using upnp at all myself Thanks for adding me. I've put together 1.8.4, but there's a so-name bump that comes with it (it should have come with 1.8.3, but they missed it there). I've never pushed a library with a so-name bump before, so I want to make sure I get this right. Should I just put out a so-name bump announcement on both the Fedora and RPM Fusion mailing lists? What about pushing out an update to F29? Is there some documentation on this part of the process that I should be following? The Fedora packages that depend on libupnp are: gerbera linphone linphone-mediastreamer The RPM Fusion packages that depend on libupnp are: amule amule-nogui mpd vlc-core A soname bump in rawhide (f30) is appropriate (then there is a need for an announcement there) But for f29 since there is a no ABI changes I would say that reverting the ABI bump could be more appropriate here. As the ABI won't change between 1.8.3 and 1.8.4, only SO number. (this would need to be verified with rpmsodiff or abigail). Maybe it could even be possible to coordinate and allow to keep the ABI number for f29 also. (I don't know what folk in #fedora-devel would say. But according to the guideline, it's forbidden). Okay, so I went ahead and made the update with the SONAME reverted to the one in fc29's libupnp 1.8.3 for both rawhide and f29. Please confirm usability. (also it seems like a recent update broke vlc, I suspect qt5 update to 5.11.3), but there are also few issue on the vlc side. Please try to reproduce with vlc-3.0.5-14.fc29 at least (http://koji.rpmfusion.org/koji/taskinfo?taskID=286234) libupnp-1.8.4-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-2bdfbe1908 I've tested it with vlc-3.0.5-14 and it's working perfectly in F29. I've left feedback in Bodhi. Thanks so much! *** Bug 1664767 has been marked as a duplicate of this bug. *** libupnp-1.8.4-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-2bdfbe1908 libupnp-1.8.4-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 1497245 [details] Partial logs Description of problem: vlc crashes whenever I try to open a uPnP stream, pointing at a problem in UpnpString_get_String in libupnp. Version-Release number of selected component (if applicable): libupnp-1.8.3-3.fc29 How reproducible: Always Steps to Reproduce: 1. Open a uPnP stream in vlc 2. Wait a few seconds 3. Actual results: vlc crashes Expected results: uPnP stream opens Additional info: The uPnP streams are provided by Kodi on a Fedora 28 system. Downgrading libupnp to 1.6.25 and rebuilding vlc against that version fixes the problem.