Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1649127 (python-brian2)
| Summary: | Review Request: python-brian2 - A clock-driven simulator for spiking neural networks | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ankur Sinha (FranciscoD) <sanjay.ankur> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zebob.m |
| Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-11-25 02:02:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1276941 | ||
|
Description
Ankur Sinha (FranciscoD)
2018-11-13 00:06:59 UTC
Rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30843505 F29 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30843512 - .cpp, .c and .h files should be in a devel subpackage Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: python3-brian2 : /usr/lib64/python3.7/site- packages/brian2/devices/cpp_standalone/brianlib/clocks.h python3-brian2 : /usr/lib64/python3.7/site- packages/brian2/devices/cpp_standalone/brianlib/common_math.h python3-brian2 : /usr/lib64/python3.7/site- packages/brian2/devices/cpp_standalone/brianlib/dynamic_array.h python3-brian2 : /usr/lib64/python3.7/site- packages/brian2/random/randomkit/randomkit.h python3-brian2 : /usr/lib64/python3.7/site-packages/brian2/synapses/stdint_compat.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-brian2 , python-brian2-doc , python-brian2-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-brian2-2.2-1.fc30.x86_64.rpm python-brian2-doc-2.2-1.fc30.noarch.rpm python-brian2-debugsource-2.2-1.fc30.x86_64.rpm python-brian2-2.2-1.fc30.src.rpm python3-brian2.x86_64: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub python3-brian2.x86_64: W: spelling-error %description -l en_US brian -> brain, bairn, Brian python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/GSLweave_rt/templates/stateupdate.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/common_group.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/common_macros.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/group_get_indices.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/group_variable_get.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/group_variable_get_conditional.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/group_variable_set.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/group_variable_set_conditional.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/ratemonitor.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/reset.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/spatialneuron_prepare.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/spatialstateupdate.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/spikegenerator.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/spikemonitor.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/statemonitor.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/stateupdate.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/summed_variable.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/synapses.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/synapses_create_array.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/synapses_create_generator.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/synapses_initialise_queue.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/synapses_push_spikes.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/codegen/runtime/weave_rt/templates/threshold.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/brianlib/clocks.h python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/brianlib/common_math.h python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/brianlib/dynamic_array.h python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/common_group.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/common_synapses.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/group_variable_set.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/group_variable_set_conditional.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/main.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/network.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/objects.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/ratemonitor.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/reset.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/run.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/spatialneuron_prepare.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/spatialstateupdate.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/spikegenerator.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/spikemonitor.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/statemonitor.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/stateupdate.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/summed_variable.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/synapses.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/synapses_classes.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/synapses_create_array.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/synapses_create_generator.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/synapses_initialise_queue.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/synapses_push_spikes.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/devices/cpp_standalone/templates/threshold.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/random/randomkit/randomkit.c python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/random/randomkit/randomkit.h python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/synapses/cspikequeue.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/synapses/cythonspikequeue.cpp python3-brian2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.7/site-packages/brian2/synapses/stdint_compat.h python-brian2.src: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub python-brian2.src: W: spelling-error %description -l en_US brian -> brain, bairn, Brian 4 packages and 0 specfiles checked; 0 errors, 59 warnings. (In reply to Robert-André Mauchin from comment #2) > - .cpp, .c and .h files should be in a devel subpackage > They aren't devel files in the usual sense---they arent used by users to build against brian. They are template files that are used by brian itself to generate standalone simulations using a code-generator. So, they are required by brian at runtime. More information on it here: https://brian2.readthedocs.io/en/stable/user/computation.html#standalone-code-generation Should these still be moved to a devel sub package? Thanks, Ankur Okay then package is approved. Thanks, Robert! SCM requested: https://pagure.io/releng/fedora-scm-requests/issue/8830 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-brian2 python-brian2-2.2-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-ca4ac3eae4 python-brian2-2.2-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f1b64d7e93 python-brian2-2.2-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f1b64d7e93 python-brian2-2.2-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-ca4ac3eae4 python-brian2-2.2-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. python-brian2-2.2-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. |