Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 165254
Summary: | Review Request: plplot - Scientific plotting package | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> | ||||
Component: | Package Review | Assignee: | Ed Hill <ed> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | ed, fedora-package-review | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
URL: | http://www.cora.nwra.com/~orion/fedora | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2005-08-10 20:45:56 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 163779 | ||||||
Attachments: |
|
Description
Orion Poplawski
2005-08-05 21:55:01 UTC
[Where did the FE-NEW entry go? The form linked in the new NewPackageProcess page fills it in automatically, doesn't it?] OK, I'm trying to change this from FE-NEW to RE-REVIEW blocking as I'd like to be the reviewer. But I don't see how to assign the bug to me per the directions: http://fedoraproject.org/wiki/Extras/NewPackageProcessMarkTwo Do I need some special permissions to change the assigned-to field or do I just fill in the QA Contact field? What happens if you use the "Bug Reassignment" radio-buttons and fields near the bottom of the page? Hi Michael, I don't have any "Bug Reassignment" radio-buttons and fields near the bottom of the page. Please see the screen-shot at: http://mitgcm.org/eh3/fedora_misc/bz_165254.png I'm wondering--is this something that only appears when you have additional permissions? Hi Orion, I started a review but only got this far. I wish I could provide more help tracking down the build failure but it'll have to be another day -- not enough free time right now! :-/ needswork: - the Source0 URL doesn't work for me -- but this one did: http://prdownloads.sourceforge.net/plplot/plplot-5.5.3.tar.gz - please consider shortening the summary to something like: "Library of functions for producing scientific plots" - build fails on FC-4 (please see below) good: - specfile is nicely formatted -- VERY legible - source matches upstream - license is indeed LGPL - names OK - ldconfig looks OK The build failure (up-to-date FC-4) is some sort of botched code generation for the plplot_octave.cc file which I just don't understand (but then I spent all of ~15min looking at it): g++ -c -fPIC -I/usr/include/octave-2.1.71 -I/usr/include/octave-2.1.71/octave -mieee-fp -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -m32 -march=i386 -mtune=pentium4 -fasynchronous-unwind-tables -mieee-fp -I. -I. plplot_octave.cc -o plplot_octave.o ./massage >> plplot_stub.m 2> missing_help plplot_octave.cc: In function 'octave_value_list _wrap_plscol0(const octave_value_list&, int)': plplot_octave.cc:2239: error: 'nt' was not declared in this scope plplot_octave.cc:2239: error: expected `;' before ')' token make[4]: *** [plplot_octave.oct] Error 1 make[4]: Leaving directory `/home/edhill/rpmbuild/BUILD/plplot-5.5.3/bindings/octave' (In reply to comment #4) > Hi Michael, I don't have any "Bug Reassignment" radio-buttons and > fields near the bottom of the page. Please see the screen-shot at: > > http://mitgcm.org/eh3/fedora_misc/bz_165254.png > > I'm wondering--is this something that only appears when you have > additional permissions? Are you logged in properly? (username visible at the top right of each bz page). Also if you are not the reporter, you will need 'editbugs' privileges to edit other people's bugs such as status changes, etc. Please speak with Elliot (sopwith) to have your username added to the Fedora Contrib Bugzilla group. This would happen automatically if you have CVS access to Fedora Extras. Hi David, I am logged in properly (user: "ed") and I sent a private "please help me" email to Elliot (in which I accidentally called you "Greg" so *please* forgive me!). I've put new versions up at http://www.cora.nwra.com/~orion/fedora/ It's fun being the first test bunny... Okay, another new version (-3) at http://www.cora.nwra.com/~orion/fedora/. This is based on the plplot-split.spec, which attempts to split the package up into several sub-packages to try to reduce dependencies. Let me know what you think. It does the major ones: gnome, octave, and tk. Since python is usually installed I haven't split that out. Hi Orion, on my FC-4 system the -3 version fails to build with a lot of errors that all say the same thing ("plplotjavac cannot be resolved") and it looks like (?) a classpath problem. === cp plplot/core/plplotjavacConstants.class . javac plplotjavac.java -d . -classpath . cp plplot/core/SWIGTYPE_p_p_char.class . javac PLStream.java -d . -classpath . ---------- 1. ERROR in PLStream.java (at line 67) plplotjavac.plsstrm(stream_id); ^^^^^^^^^^^ plplotjavac cannot be resolved ---------- 2. ERROR in PLStream.java (at line 108) plplotjavac.pl_setcontlabelformat(lexp, sigdig); ^^^^^^^^^^^ plplotjavac cannot be resolved I haven't checked all details, but as it seems to me, when rebuilding the package outside of a buildsystem, the configure script picks up arbitrary features, depending on which packages are installed on a system. So, I'd suggest you to check if you need to append --disable-<feature> or --with-<package>=no to %configure to make building the package deterministic. Created attachment 117575 [details]
rpmlint output for mock build of plplot-5.5.3-4.fc4
Hi Orion, the version: http://www.cora.nwra.com/~orion/fedora/plplot-5.5.3-4.src.rpm built in mock on FC-4 but resulted in a few rpmlint errors and warnings which I created as attachment 117575 [details] (above). I think some of the libexec stuff can be safely ignored but others probably need work. Okay, released -5 which cleans up a bunch of rpmlint issues and explicitly turns off unused options with configure. It also adds %check/make check and some fixes to some problems that that turned up. I still get the following rpmlint messages, but I'm going to ignore them: W: plplot-gnome summary-not-capitalized plplot funtions for gnome W: plplot-gnome no-documentation W: plplot-tk summary-not-capitalized plplot funtions for tk E: plplot-tk no-dependency-on locales-tk W: plplot-gnome-devel summary-not-capitalized plplot libraries for gnome W: plplot-gnome-devel no-documentation W: plplot-octave summary-not-capitalized plplot funtions for octave W: plplot-octave no-documentation W: plplot-octave non-standard-dir-in-usr libexec W: plplot-tk-devel summary-not-capitalized plplot libraries for tk W: plplot-tk-devel no-documentation E: plplot-tk-devel wrong-script-interpreter /usr/share/plplot5.5.3/examples/tk/tk01 "xtk01" E: plplot-tk-devel wrong-script-interpreter /usr/share/plplot5.5.3/examples/tk/tk04 "xtk04" E: plplot-tk-devel wrong-script-interpreter /usr/share/plplot5.5.3/examples/tk/tk02 "xtk02" The last 3 are spurious because the example sripts really do run with a different interpreter. W: plplot-gnome summary-not-capitalized plplot funtions for gnome W: plplot-tk summary-not-capitalized plplot funtions for tk W: plplot-gnome-devel summary-not-capitalized plplot libraries for gnome W: plplot-octave summary-not-capitalized plplot funtions for octave W: plplot-tk-devel summary-not-capitalized plplot libraries for tk Surely it is common to fix these. (Even openSUSE have guidelines for this.) In these cases: * Capitalise first character. * Don't repeat package name at beginning of Summary. * s/funtions/functions/g E.g. plplot-gnome : Functions for scientific plotting with GNOME plplot-tk : Functions for scientific plotting with Tk plplot-gnome-devel : Development files for using PLplot GNOME plplot-octave : Functions for scientific plotting with Octave plplot-tk-devel : Development files for using PLplot with Tk or similar. True, I'll stop being lazy. Repushed -5 with updated summaries. Hi Orion, the package is looking good and heres the second half of the review that started in comment #5 needswork: - rpmlint reports: W: plplot-gnome no-documentation W: plplot-gnome-devel no-documentation W: plplot-octave no-documentation W: plplot-octave non-standard-dir-in-usr libexec E: plplot-tk no-dependency-on locales-tk W: plplot-tk-devel no-documentation E: plplot-tk-devel wrong-script-interpreter /usr/share/plplot5.5.3/examples/tk/tk01 "xtk01" E: plplot-tk-devel wrong-script-interpreter /usr/share/plplot5.5.3/examples/tk/tk04 "xtk04" E: plplot-tk-devel wrong-script-interpreter /usr/share/plplot5.5.3/examples/tk/tk02 "xtk02" where I think everything can be safely ignored except for the "no-dependency-on locales-tk" which I just don't understand. Hopefully, someone else can explain it. Anyone...? - plplot-gnome and plplot-tk both install shared libs so please add a set of %post/%postun -p /sbin/ldconfig entries for those two sub-packages good: - needswork items from #5 are now OK - dir ownership looks OK - permissions look OK - code not content OK - use of -devel looks good - builds in mock on FC-4 Since the remaining bits appear to be minor, please fix them in CVS before the first build and I'll APPROVE. locales-tk stuff from rpmlint is bug 165457. Added the post/postun ldconfig Checked in and builds on FC-4 (with a fix for x86_64). Working on devel... Thanks Ed! Cool, I'm glad that its working and am looking forward to giving it a try. One of the unexpected (for me, anyway) benefits of FE is finding out about these useful progects/libs/etc. Who knew all this stuff existed? |