Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 165303

Summary:	Review Request: OpenSceneGraph
Product:	[Fedora] Fedora	Reporter:	Ralf Corsepius <rc040203>
Component:	Package Review	Assignee:	Michael Schwendt <bugs.michael>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	byte, fedora-package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://www.openscenegraph.org
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-08-31 16:11:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Ralf Corsepius 2005-08-07 11:02:33 UTC

Spec Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/OpenSceneGraph.spec
SRPM Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/OpenSceneGraph-0.9.9-1.src.rpm

Description:
The OpenSceneGraph is an OpenSource, cross platform graphics toolkit for the
development of high performance graphics applications such as flight
simulators, games, virtual reality and scientific visualization.
Based around the concept of a SceneGraph, it provides an object oriented
framework on top of OpenGL freeing the developer from implementing and
optimizing low level graphics calls, and provides many additional utilities
for rapid development of graphics applications.

Warning: Due to possibilities to test building on x86_64 or ppc, and due to oddities of this package's configuration, I do not expect this package to build on x86_64 or ppc.

Comment 1 Colin Charles 2005-08-08 00:32:55 UTC

+ It built on ppc32 just fine.

- What is OSLGPL as a license?

(this is by no means a complete review though the spec looks clean, it builds on
PPC, rpmlint throws up a few errors that don't look too important)

Comment 2 Ralf Corsepius 2005-08-08 06:17:19 UTC

(In reply to comment #1)
> + It built on ppc32 just fine.
Good, thanks. x86_64 probably is more troublesome :(

> - What is OSLGPL as a license?
A typo - This should have been OSGPL (OpenSceneGraph Public License).

It's their "LGPL + special exceptions" variant. Cf. OpenSceneGraph/LICENSE.txt
and Producer/LICENSE.txt.

Comment 3 Ralf Corsepius 2005-08-09 15:32:56 UTC

Update with minor fixes applied:
Spec Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/OpenSceneGraph.spec
SRPM Name or Url:
ftp://packman.iu-bremen.de/fedora/SRPMS/OpenSceneGraph-0.9.9-2.src.rpm

Comment 4 Michael Schwendt 2005-08-26 19:06:41 UTC

Not much to find:

* weak one-word description and summary for OpenThreads* packages
  and Producer* packages

* lots of C++ files which don't build with default RPM optflags,
  but just -O optimisation

* x86_64 X11 lib64->lib substitution is questionable
  in openscenegraph_0.9.9-5.diff.gz, probably needs to be reverted
  in the revdeb patch, too

* hardcoded ${exec_prefix}/lib in pkgconfig files most likely
  will cause install-time problems on x86_64

* Producer-devel pkgconfig file requires "openscenegraph"
  => I think that dependency is wrong

* OpenSceneGraph-devel pkgconfig requires "openthreads"
  => package is missing "Requires: OpenThreads-devel"

* OpenSceneGraph-examples package contains questionable empty directory
  /usr/share/OpenSceneGraph

* random examples run-time test:

$ osgforest
Warning: could not find file "Images/tree0.rgba"
Warning: font file "fonts/arial.ttf" not found.