Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 165407
Summary: | Review Request: srecord - Manipulate EPROM load files | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jose Pedro Oliveira <jose.p.oliveira.oss> |
Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review |
Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://srecord.sourceforge.net/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-09-23 13:35:19 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Jose Pedro Oliveira
2005-08-09 00:44:49 UTC
http://gsd.di.uminho.pt/jpo/software/fedora/srecord-1.22-1.src.rpm Changelog: * Update to 1.22. Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file NEEDSWORK: Source does NOT match upstream: md5sum srecord-1.22.tar.gz rpmbuild/SOURCES/srecord-1.22.tar.gz d67c70be352486db6a9c0929a4d8f08e srecord-1.22.tar.gz 01ee85525efd8bbbec9b80ddec44576d rpmbuild/SOURCES/srecord-1.22.tar.gz Minor nitpick: make could use %{?_smp_mflags}. Fix the source to match upstream, and I'll recheck. (In reply to comment #2) > Source does NOT match upstream: > > md5sum srecord-1.22.tar.gz rpmbuild/SOURCES/srecord-1.22.tar.gz > d67c70be352486db6a9c0929a4d8f08e srecord-1.22.tar.gz > 01ee85525efd8bbbec9b80ddec44576d rpmbuild/SOURCES/srecord-1.22.tar.gz The author made different tarballs for the same package version * I used the one in the heanet mirror http://heanet.dl.sourceforge.net/sourceforge/srecord/srecord-1.22.tar.gz * which is older (and different) from the one in the mains URl http://srecord.sourceforge.net/%{name}-%{version}.tar.gz main url --> #define PATCHLEVEL "1.22.D002" (tarball date 20050905) sf mirrors (heanet) --> #define PATCHLEVEL "1.22.D001" (tarball 20050812) Going to update use the tarball to the latest patchlevel > > Minor nitpick: > > make could use %{?_smp_mflags}. > I had problems compiling it in a SMP machine. I will give another try using the Extras building system. > Fix the source to match upstream, and I'll recheck. http://gsd.di.uminho.pt/jpo/software/fedora/srecord-1.22-2.src.rpm (In reply to comment #3) > The author made different tarballs for the same package version Tsk, tsk. Bad upstream author! > I had problems compiling it in a SMP machine. I will give > another try using the Extras building system. If it doesn't work, don't waste time with it. Just throw in a comment about it not building properly with smp mflags. APPROVED. Updated to version 1.23. This new version corrects the segmentation fault that occured during the regression test suite in x86_64 (reported upstream). Release notes (README file) Version 1.23 (23-Sep-2005) * A segfault has been fixed on x86_64 when running the regression test suite. * A compile problem with the lib/srec/output/file/c.cc file has been fixed. ... Package Change Request ====================== Package Name: srecord New Branches: el6 Owners: spot Git done (by process-git-requests). |