Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 165413
| Summary: | Review Request: plague RPM build system | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dan Williams <dcbw> |
| Component: | Package Review | Assignee: | Josh Boyer <jwboyer> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, scop |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://people.redhat.com/dcbw/plague/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-08-21 14:37:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Dan Williams
2005-08-09 03:27:08 UTC
Two initial minor issues:
1) Buildroot should be:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
to keep with the Extras packaging guidelines
2) I think the Requires: for pyOpenSSL can be dropped in all sub-packages except
plague-common since everything else already depends on plague-common.
I'll do a bit more looking and see if i notice anything else, but it looks
pretty good so far.
fair enough. will respin packages and upload with these changes. I see no other issues. The package builds and installs on both FC-3 and FC-4. It is obviously working since all of Extras is relying on it. I approve this package. Oops, wrong blocker bug. :) Fixes done, will be imported as plague-0.3.1-1 imported and building owners.list entry in CVS (and thus Bugzilla component, I guess) still missing. added to owners.list now. thanks for pointing that out. |