Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 165456
| Summary: | Review Request: fnfx - Enables hotkey functions for Toshiba laptop | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andreas Bierfert <andreas.bierfert> | ||||||
| Component: | Package Review | Assignee: | Matthias Saou <matthias> | ||||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora-package-review | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | http://fnfx.sourceforge.net | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2005-08-24 00:48:03 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 163779 | ||||||||
| Attachments: |
|
||||||||
|
Description
Andreas Bierfert
2005-08-09 15:49:33 UTC
Attached is a patch to the spec file to fix minor issues. The first real blocker would have been that the _sysconfdir/fnfx/ directory was unowned by the package, thus not removed upon uninstall. The second maybe the execution bit of the init script after storing the file in CVS, as it wasn't explicitely set anywhere. Now for the init script : Things seem wrong, as if the daemon crashes, then the /var/lock/subsys/fnfxd will be left over, and given how the checks are made, it will prevent it from being started again, and even forcing a stop or restart won't get rid of the file. Created attachment 117905 [details]
Spec file patch
I still don't know about the init script but the rest is fixed: http://fedora.lowlatency.de/review/fnfx-0.3-3.src.rpm http://fedora.lowlatency.de/review/fnfx.spec ping? I would say for the script part: Leave it as is and if problems arise find a way to fix them. I think it is ok the way it is. No, the init script is definitely not ok the way it is. There is also a "RETVAL=$?" after "echo" (always true) instead of after the "killproc" call which will have the script return a wrong exit status in some occasions. Attached is a completely new init script. It fixes all the issues I've seen, but is completely untested, so please give it a try in case I've missed something. Note that I've enabled the service by default for runlevels 2345. This is something we don't want to do often, but for such a specific service that doesn't do any kind of network access, it should be considered ok, and will save the end user the step of manually enabling the service. Created attachment 118000 [details]
New init script
Thx for your work =) I am not into init scripts that much... http://fedora.lowlatency.de/review/fnfx-0.3-4.src.rpm http://fedora.lowlatency.de/review/fnfx.spec Can you confirm that the init script is working? As soon as that's confirmed, I'll approve the package :-) The script looks good (in comparison to other scripts) and does what is expected on my computer.. problem is: I don't have a toshiba laptop and this packages was actually the reason for a friend of mine not to switch to fc (yet ;) ) so this is why I initially put it up here... I will say it like this: It does not bail on anything I am doing but I can not test the real thing here. OK, then go ahead and import the package. Reminder: http://fedoraproject.org/wiki/Extras/NewPackageProcessMarkTwo Things are easier to track if they flow according to the process; a new submission should be closed (by the submitter) only after it's in CVS and successfully built. Normalize summary field for easy parsing |