Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 165489
Summary: | Review Request: airsnort - Wireless LAN (WLAN) tool which recovers encryption keys | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Andreas Bierfert <andreas.bierfert> |
Component: | Package Review | Assignee: | Orion Poplawski <orion> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, orion |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://airsnort.shmoo.com/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-08-11 16:38:43 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Andreas Bierfert
2005-08-09 19:14:52 UTC
Still don't seem to be able to assign bugs to myself, not sure why. Greg - can you fix this? Review: Mostly looks quite good except for: # rpmlint airsnort W: airsnort no-version-in-last-changelog changelog should be like: * Thu Jun 02 2005 Andreas Bierfert <andreas.bierfert[AT]lowlatency.de> - 0.2.7e-3 Need: BuildRequires: desktop-file-utils or BuildRequires: /usr/bin/desktop-file-install to build in mock. Also, no icon has appeared in my KDE menu. desktop file shows: # cat /usr/share/applications/fedora-airsnort.desktop [Desktop Entry] Name=airsnort Comment=Wireless LAN (WLAN) tool which recovers encryption keys Exec=airsnort Terminal=false Type=Application Encoding=UTF-8 Categories=Application;System;X-Fedora; X-Desktop-File-Install-Version=0.10 Any ideas anyone? If you want/need an icon you need to specify one in the .desktop file: Icon=app_foo_icon.png Oops, I said Icon when I ment entry. I just don't see it in any of my menus. You need a relevant entry in Categories. For example, if the keyword "Network" appears, it then goes in the Internet menu. Where do you think it should go? I would say "Internet" or possibly "System Tools". Then, add --add-category "Network" to the desktop-file-install command in the specfile and you should be good. Ok here you go: Fixed BR and .desktop file and added missing changelog version ... http://fedora.lowlatency.de/review/airsnort.spec http://fedora.lowlatency.de/review/airsnort-0.2.7e-4.src.rpm I'm still not seeing a menu item, but this may just be a local thing. Still see: W: airsnort no-version-in-last-changelog Formatting is messed up from wrapping. End of line should be like: <email> - 0.2.7e-4 All on one line, with a "-" separator. Easily fixed, so Approved. Thanks... I will commit it asap... As to the changelog: This has been talked about before and agreed to be ok in this case because my name, mail combination is quiet long :) Normalize summary field for easy parsing |