Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 165509
Summary: | Review Request: link-grammar - Addition of link-grammar to FC Extras | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Marc Maurer <uwog> |
Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, gauret, matthias |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.abisource.com/~uwog/link-grammar/link-grammar-4.1.3-1.src.rpm | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-08-11 16:40:06 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Marc Maurer
2005-08-09 22:29:46 UTC
Why use Epoch ? Since it it the first submission in Fedora, please remove it (and the %{epoch} in Requires) Other than that, it seems to build fine and to run fine. Just a few rpmlint gotchas: W: link-grammar-devel summary-ended-with-dot E: link-grammar-devel description-line-too-long > Why use Epoch? Bad copy/pasting :) Fixed, the new spec is available under the previously posted url. I fixed the rpmlint errors too; the new srpm is available here: http://www.abisource.com/~uwog/link-grammar/link-grammar-4.1.3-2.src.rpm One last thing: the package should own the %{_datadir}/link-grammar directory. Just do : -%{_datadir}/link-grammar/* +%{_datadir}/link-grammar in %files. Two comments (since you'll rebuild anyway ;)) : - you can use disttags (if you want, just in case you forgot) - the buildroot should be set to the standard one in Fedora : %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Fixed the %{_datadir}/link-grammar and buildroot issues; for devel I genally don't use disttags. When devel becomes FCE5 I'll add them. The new spec is available under the previously posted url, and the new SRPM can be found here: http://www.abisource.com/~uwog/link-grammar/link-grammar-4.1.3-3.src.rpm Thanks for the pointers. Looks good. Approved. [Sorry for the bugzilla spam everyone, but without assigning the tickets, it doesn't become clear in the FE-* dependency trees who did which reviews.] (In reply to comment #3) > Just do : > -%{_datadir}/link-grammar/* > +%{_datadir}/link-grammar > in %files. I'd suggest using : %{_datadir}/link-grammar/ As that way it still makes it clear that it's a directory. It's only cosmetical and doesn't affect the package in any way, though. Normalize summary field for easy parsing |