Bug 165612

Review:
* BuildRoot: should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Missing SMP flags ( make %{?_smp_mflags} )
* BuildRquires should be gtk+-devel, not gtk+. Please tests your package build
  in mock to make sure no BR is missing.
* Please drop the Mandriva-specific header
* Don't set Vendor or Packager, they are set by the build system
* just use %configure instead of ./configure --prefix=
* replace /usr/share/ with %{_datadir}
* install with "make DESTDIR=$RPM_BUILD_ROOT install"
* %post is empty, you can remove it
* in the %files list, use %{_bindir} instead of %{prefix}/bin and %{_datadir} 
  instead of %{prefix}/share
* use the %{find_lang} macro to find the language files and tag them as such.
An example spec file for Fedora can be found in the fedora-rpmdevtools package

http://mpeters.us/fc_extras/gfontview-0.5.0-3.fc4.src.rpm
http://mpeters.us/fc_extras/gfontview.spec

I hope this isn't too presumptuos of me, but despite it being gtk+ (opposed to
gtk2+) - this looks like an app that will be particularly useful for something
personal I am working on at the moment - so I went ahead and cleaned up the spec
file and got it to build in mock.

There are still three (trivial) issues I am aware of:

1) Patch0 needs its name changed
2) the desktop file needs to be modified somewhat
3) I should have changed the Group (rpmlint doesn't like it)

Aurelien, other than those issues, do my modifications to spec file look OK to you?

Kirby, are you OK with those changes?

-=-
Oh - I verified source tarball matches upstream as well.

Those changes are OK with me, with a few exceptions :
- in the ./configure there is :
checking for gnome-config... no
===>Gnome not found. Building without it.
Missing BuildRequires ?
- The config file is installed in /usr/share/gfontviewrc
- each %files section should have a %defattr line 
  (wiki: PackageReviewGuidelines)
- Desktop file: the Categories tag should contain Application 
  (wiki: PackagingGuidelines#desktop)

Whose name is going to be put in owners.list, and therefore who's going to be
the assignee for gfontview's bugs ?

> 
> Whose name is going to be put in owners.list, and therefore who's going to be
> the assignee for gfontview's bugs ?

Kirby is the owner/maintainer.
He would have to accept the changes (or make some on his own that fix the
issues) before it could be approved.

If Kirby hasn't been sponsored, I would be willing to import/maintain it until
has been sponsored. The spec file I did is for him to use if he wants it. This
tool is a lot nicer than xfd for viewing fonts, I primarily modified the spec so
I could build it and use it myself.

Thanks Aurelien and Michael both. I appreciate the updated spec, and I'll add
the rest of these changes to my spec. One question: what *should* the config
file path be, if not /usr/share/gfontview?

I have no CVS privileges, so I would love it if you could import the project for
me, Michael. I am definitely not the owner, but in the absence of a responsive
owner of the upstream source, would be happy to be a maintainer.

I think gfontviewrc should be in /usr/share/gfontview/
That's where Debian puts it.

In a few minutes I'll upload a newer version of my spec file that should address
everything.

./configure is looking for the old gnome-config binary (using AC_PATH_PROG) to
figure out the path for gnome libraries. What test should it use to find if
libgnome is available?

You don't. You add gnome-libs-devel to BuildRequires.

> I think gfontviewrc should be in /usr/share/gfontview/

Yes, the idea is that there should only be directories in /usr/share (with a few
exceptions)

> ./configure is looking for the old gnome-config binary

Since gfontview is a gtk+ app, there is probably no way to make it work with
GNOME 2+...

I've uploaded a new spec file

http://mpeters.us/fc_extras/gfontview.spec
http://mpeters.us/fc_extras/gfontview-0.5.0-4.fc4.src.rpm

I *think* that should take care everything if Kirby wants to use them.

Review for release 4.fc4:
* RPM name is OK
* Source gfontview-0.5.0.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint of gfontview looks OK
* File list of gfontview looks OK
* Works fine

Kirby, if you're OK with those changes, you're APPROVED.

Thanks, Michael, for all your work on this. Looking at what you did explains a
lot to me about how to package things correctly. I think you spec and patches
look fine.

So what's the next step towards inclusion? Can someone help me by importing the
package into CVS?

Aurelien Bompard -

Is it OK if I import this into CVS and take temporary owenership until Kirby is
sponsored?

Fine with me. Kirby, did you ask for a sponsor ? What you now have to do is
described here : http://fedoraproject.org/wiki/Extras/Contributors. You're at
step 8.

Imported into cvs, branched for fc-3 fc-4, builds on all platforms for
fc-3/fc-4/devel

Kirby, when you get a sponsor, you can take ownership.