Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 165957
Summary: | Review Request: esmtp. Relay only MTA. | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Patrice Dumas <pertusus> |
Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, gauret |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://esmtp.sourceforge.net/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-07-23 12:39:22 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Patrice Dumas
2005-08-15 10:21:27 UTC
I took the upstream spec tweaked it a little. I used the alternative system copying what is done for exim, so that it can be a sendmail replacement and provide smtpdaemon. It might not be a good idea as fetchmail requires a smtpdaemon that listen on the smtp port as a fallback in case the mda don't accept mail, so it is not a real replacement for smtpdaemon which corresponds with 2 (orthogonal) things, a send mail MTA and a SMTP receiving daemon. See for example https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=66396#c4 I have a better srpm with a Source url that works: http://www.environnement.ens.fr/docs/fc-srpms/esmtp-0.5.1-4.src.rpm * I would advise against providing smtpdaemon, since esmtp is not a daemon at all, and programs like fetchmail could think their requirement is fulfilled while it is not (nothing listening on port 25) * Don't put the german translation in the filename. IIRC the policy it not to include translations except if the package is strongly related to a particular language (which is not the case here) * Spec file encoding should be either ASCII UTF-8, but I think this will be solved when the german parts are gone. * PreReq should be Requires(post) * Missing BuildRequires: openssl-devel * To copy source 1 I would just do "cp %{SOURCE1} mutt-esmtp ." since the working directory is the building dir, but that's minor. I removed the provide smtpdaemon, now the drawback is that mutt require smtpdaemon, so a smtp listener must be installed even though none is needed. I changed the german accents to utf-8, and then put the translations in comments such that they are not lost. The PreReq came from exim.spec... Thanks for the explanation. openssl-devel is not BuildRequired, it is a dependency for libesmtp-devel. I filled a bug against libesmtp. I copy the mutt-esmtp now in the %setup using your command. See the srpm here: http://www.environnement.ens.fr/docs/fc-srpms/esmtp-0.5.1-5.src.rpm > I removed the provide smtpdaemon, now the drawback is that mutt require > smtpdaemon, so a smtp listener must be installed even though none is needed. Right... I don't know what the best solution would be, maybe you should ask fedora-extras-list... > openssl-devel is not BuildRequired, it is a dependency for libesmtp-devel. I > filled a bug against libesmtp. You're right, but the package won't build in the buildsystem as long as openssl-devel is not buildrequired in a way or another. Could you add the BR temporarily and remove it when libesmtp-devel is fixed ? The spec file is still not utf-8 : $ file esmtp.spec esmtp.spec: ISO-8859 English text you can use "recode ISO-8859-1..UTF-8 esmtp.spec" to convert it Apart from that everything looks OK. Regarding smtpdaemon I think it is not a terrible issue, lets keep it like this. Hopefully the utf8 issue is solved and I added the BR in: http://www.environnement.ens.fr/docs/fc-srpms/esmtp-0.5.1-6.src.rpm Looks good : * RPM name is OK * Spec change looks OK * Source esmtp-0.5.1.tar.bz2 is the same as upstream * The BuildRoot is the preferred one * Builds fine in mock * rpmlint agrees * Seems to be working fine According to http://fedoraproject.org/wiki/PackageReviewGuidelines, I was mistaken about the german translation. Please re-enable it before or after importing into CVS. Thanks I reenabled the german translations and built. Aurelien, you should assign that bug to yourself. Done, thanks |