Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 165988
Summary: | Review Request: cppunit. C++ Port of JUnit Testing Framework | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Patrice Dumas <pertusus> | ||||
Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | fedora-package-review | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
URL: | http://cppunit.sourceforge.net/ | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2005-09-28 06:45:00 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 163779 | ||||||
Attachments: |
|
Description
Patrice Dumas
2005-08-15 14:51:10 UTC
Created attachment 117754 [details]
spec file changes for FE
This one needs a little more love. I actually had cppunit in my never-ending
queue of new packages, so I was able to add some fixes to your spec file.
If you make those changes, I'll approve this one. I am not persuaded that it is necessary to split in a devel package but if you want too... Regarding the summary it is clearer but may not be precise enough as if I'm not wrong there are other C++ unit testing frameworks. I didn't had graphviz and cppunit built fine, why is it needed? Anyway I'll republish the srpm with your change if you confirm that graphviz is needed. The summary is supposed to be minimal. The description is where the real meat comes in. :) Yes, I want to split to a -devel package. No need to take up space if its not needed. Graphviz is used to generate the graphs in the documentation. Without it, the docs still build, but they don't have graphs. Here is the srpm: http://www.environnement.ens.fr/docs/fc-srpms/cppunit-1.11.0-2.src.rpm - rpmlint checks return: W: cppunit-devel no-documentation Safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (LGPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r APPROVED. (sorry it took so long) I packaged cppunit because opendap uses it a lot, but I don't know what it is. Do you want to take ownership? Otherwise i can update when new versions are out... In the build log there are errors that don't appear in my local builds. I believe this corresponds with a missing dependency. Error: fontconfig: Couldn't retrieve font family name. : Helvetica I have skimmed through the docs and found that it is likely that the missing font is a font used for the graphs (in the packaged version the text in boxes seems to be monospaced and overflow from the boxes). Maybe it is a missing dependency for graphviz? Or for cppunit, but I haven't more clue. I have reported thee issue on the fedora extras list. Closing. |