Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166092
Summary: | Review Request: python-myghty - A Python-based templating system derived from HTML::Mason | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Luke Macken <lmacken> |
Component: | Package Review | Assignee: | José Matos <jamatos> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, kim, pfrields |
Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.myghty.org | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-09-14 11:44:56 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Luke Macken
2005-08-16 20:38:03 UTC
Updated Spec and SRPM to the latest version: 0.98c http://people.redhat.com/lmacken/python-myghty.spec http://people.redhat.com/lmacken/python-myghty-0.98c-1.src.rpm Still waiting for reviewers... + builds in mock on x86_64 + rpmlint issues no warnings + meets naming/packaging guidelines + license is correct (LGPL), matches upstream + spec is legible in American English + Build and BuildRequires are correct + source matches upstream I have some problems with the package: - license is not included in the package - does it makes sense to pass -O1 to setup.py install for a noarch package? If you fix the first issue then consider the package Approved. (In reply to comment #2) > - does it makes sense to pass -O1 to setup.py install for a noarch package? It generates .pyo files as well as .pyc files. (In reply to comment #3) > > - does it makes sense to pass -O1 to setup.py install for a noarch > > package? > It generates .pyo files as well as .pyc files. Yes, I know. :-) I am questioning if they are, or not, arch independent. I always forget this. But as I have told above this is a minor point. LICENSE is now included in the package. The package is Approved as I have said before. I have verified that all the noarch python-* packages follow the same procedure, building with -O1. python-myghty committed and added to owners.list file. Thanks! Package Change Request ====================== Package Name: python-webhelpers New Branches: epel7 Owners: lmacken kim27 InitialCC: Please see #1175527 for request for epel 7 status. Branch exists. Package Change Request ====================== Package Name: python-myghty New Branches: epel7 Owners: lmacken kim27 InitialCC: Please see #1175527 for request for epel 7 status. Helps if I put the right package name. :-/ Git done (by process-git-requests). |