Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166187
| Summary: | Review Request: perl-Class-DBI-FromCGI : Update Class::DBI data using CGI::Untaint | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> | ||||
| Component: | Package Review | Assignee: | Paul Howarth <paul> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | http://search.cpan.org/dist/Class-DBI-FromCGI/ | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2005-09-08 15:40:03 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 166181, 166184 | ||||||
| Bug Blocks: | 163779, 166203 | ||||||
| Attachments: |
|
||||||
|
Description
Tom "spot" Callaway
2005-08-17 20:28:07 UTC
Review:
- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec
- spec written in English and is legible
- sources match upstream
- package builds OK on FC4 and in mock for rawhide (i386)
- BR's mostly OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets
Needswork:
- remove redundant BR: perl
- include license text
Nitpick:
- honor %%{_smp_mflags}
- add BR: perl(DBD::SQLite) for better test cover
Created attachment 118551 [details]
Patch addressing review issues
Fixed in -3: SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-FromCGI-0.94-3.src.rpm SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-FromCGI.spec Approved. |