Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166195
| Summary: | Review Request: perl-Class-DBI-SQLite : Extension to Class::DBI for sqlite | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> | ||||
| Component: | Package Review | Assignee: | Paul Howarth <paul> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | http://search.cpan.org/dist/Class-DBI-SQLite/ | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2005-09-04 22:18:55 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 166184 | ||||||
| Bug Blocks: | 163779, 166188, 166203 | ||||||
| Attachments: |
|
||||||
|
Description
Tom "spot" Callaway
2005-08-17 20:40:51 UTC
Review:
- rpmlint clean
- package and spec file names OK
- package meets guidelines
- license is same as perl, matches spec
- spec file written in ENgish and is legible
- sources match upstream
- builds OK in mock on FC4 (i386)
- buildreqs mostly OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets
Needswork:
- redundant BR: perl
- license text not included
- BR: perl(DBD::SQLite) needed
Nitpicks:
- there is now a version 0.10 at CPAN
- %{?_smp_mflags} could be used with make in %build
Created attachment 118352 [details]
Patch addressing review issues
(obviously doesn't include update to 0.10...)
0.10-1 has all the issues covered. SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-SQLite-0.10-1.src.rpm SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-SQLite.spec Explicit "Requires: perl(Class::DBI)" is no longer needed; can be fixed in CVS. Approved. I think that this is probably needed: Requires: perl(DBD::SQLite) |