Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166196
| Summary: | Review Request: perl-Class-DBI-mysql : Extensions to Class::DBI for MySQL | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> | ||||
| Component: | Package Review | Assignee: | Paul Howarth <paul> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | http://search.cpan.org/dist/Class-DBI-mysql/ | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2005-09-07 18:50:58 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 166184 | ||||||
| Bug Blocks: | 163779, 166188, 166203 | ||||||
| Attachments: |
|
||||||
|
Description
Tom "spot" Callaway
2005-08-17 20:42:15 UTC
Review:
- rpmlint clean
- package and spec file naming OK
- package meets guidelines
- license is same as perl, matches spec
- spec written in English and is legible
- source matches upstream
- package builds OK in mock on FC4 (i386)
- BR's mostly OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets
Needswork:
- redundant BR: perl
- license text not included
- BR: perl(DBD::mysql) needed; I suspect that this may also be needed as a
manual Requires:, as might perl(DBD::SQLite) for the SQLite equivalent of
this module, but I don't know enough to confirm this
Suggestions:
- the module tries to use Time::Piece::MySQL if it's available; since this
module is available in Extras, it might be useful to include this as a
manual dependency
- use %{?_smp_mflags}
Created attachment 118383 [details]
Patch addressing review issues
Fixed in -3. SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-mysql-0.23-3.src.rpm SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-mysql.spec Approved. |