Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166199
| Summary: | Review Request: perl-Data-Page : Help when paging through sets of results | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> | ||||
| Component: | Package Review | Assignee: | Paul Howarth <paul> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | http://search.cpan.org/dist/Data-Page/ | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2005-08-31 01:50:14 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 166183 | ||||||
| Bug Blocks: | 163779, 166190 | ||||||
| Attachments: |
|
||||||
|
Description
Tom "spot" Callaway
2005-08-17 20:46:36 UTC
Review:
- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, spec matches
- spec written in English and is legible
- sources match upstream
- package builds OK in mock for FC4 (i386)
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership or permissions errors
- %clean section present and correct
- macro usage consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets
Needswork:
- explicit Requires: perl(Class::Accessor::Chained::Fast) needed, not picked up
automatically
Nitpick:
- redundant BR: perl
- license text not included; suggest the usual fix
- suggest including CHANGES as %doc
- make called without %{?_smp_mflags}
- BR: perl(Class::Accessor::Chained) should really be
perl(Class::Accessor::Chained::Fast), though the same package provides both
- add BR: perl(Test::Pod) & perl(Test::Pod::Coverage) for improved test cover
Created attachment 118105 [details]
Patch addressing review issues
All issues fixed in -3. New SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-Data-Page-2.00-3.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-Data-Page.spec Approved. |