Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166208
| Summary: | Review Request: tinyerp : Open Source ERP Client | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
| Component: | Package Review | Assignee: | José Matos <jamatos> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://tinyerp.org | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-08-29 09:01:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Tom "spot" Callaway
2005-08-17 20:59:04 UTC
Review Request: tinyerp : Open Source ERP Client I copy parts of a message sent to the extras list before: The package seems interesting but I am unable to make it: + ./setup.py build Xlib: connection to "localhost:0.0" refused by server Xlib: No protocol specified This is what I get using mock. I am building the packages remotely and I would expect for the fedora build system to fail as well in this case. The culprit it is clearly the pygtk2 detection code that requires an X server to be running to confirm that the package is present. Is there any other alternative for this? Hmm. Good point. I worked around this by using Xvfb instead. Take a look at -6: New SRPM: http://www.auroralinux.org/people/spot/review/tinyerp-2.1.3-6.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/tinyerp.spec + It builds cleanly in mock for FC4/i386
+ rpmlint gives:
E: tinyerp
incorrect-locale-sv /usr/share/locale/sw/LC_MESSAGES/tinyerp-client.mo
(weird)
E: tinyerp-server explicit-lib-dependency libxml2-python
E: tinyerp-server explicit-lib-dependency libxslt-python
(it is just rpmlint being silly, can be ignored)
E: tinyerp-server
non-executable-script /usr/lib/python2.4/site-packages/tinyerp_server/report/render/rml2pdf/trml2pdf.py
0644
E: tinyerp-server
non-executable-script /usr/lib/python2.4/site-packages/tinyerp_server/addons/stock/stock.py
0644
E: tinyerp-server
non-executable-script /usr/lib/python2.4/site-packages/tinyerp_server/report/render/rml2html/rml2html.py
0644
E: tinyerp-server
non-executable-script /usr/lib/python2.4/site-packages/tinyerp_server/netsvc.py
0644
(I trust your judgment here.)
+ license is correct (GPL) and is present in both packages
+ %find_lang use
+ spec file is written in English and is readable
+ %{?dist} use
+ desktop entry
+ %files is correct and it handles directory ownership correctly
+ sha1sum of sources is the same as upstream
+ %subject is OK
+ %description is OK
After all this consider it APPROVED.
Reopening bug to fix assignee. Assignee fixed, closing again. |