Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166209
Summary: | Review Request: apcupsd - APC UPS Power Control Daemon for Linux | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> | ||||
Component: | Package Review | Assignee: | John Mahowald <jpmahowald> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | Flags: | kevin:
fedora-cvs+
|
||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
URL: | http://www.cora.nwra.com/~orion/fedora/ | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2005-11-01 16:40:18 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 163779 | ||||||
Attachments: |
|
Description
Orion Poplawski
2005-08-17 21:03:12 UTC
Build failed, will need some cleaning up. * rpmbuilding the SRPM it does not create executables. I get the following: gmake[1]: Entering directory `/home/build/rpmbuild/BUILD/apcupsd-3.10.18/src' gcc -g -O apcupsd.o apcoptd.o apcnet.o apcreports.o apcaction.o apcnis.o apcdevice.o /home/build/rpmbuild/BUILD/apcupsd-3.10.18/src/drivers/libdrivers.a /home/build/rpmbuild/BUILD/apcupsd-3.10.18/src/lib/libapc.a -lpthread -o apcupsd apcupsd.o(.text+0x36b): In function `main': /home/build/rpmbuild/BUILD/apcupsd-3.10.18/src/apcupsd.c:266: undefined reference to `attach_driver' collect2: ld returned 1 exit status gmake[1]: *** [apcupsd] Error 1 * Some missing files: File not found: /var/tmp/apcupsd-3.10.18-1-root-build/etc/apcupsd/hosts.conf File not found: /var/tmp/apcupsd-3.10.18-1-root-build/etc/apcupsd/multimon.conf File not found by glob: /var/tmp/apcupsd-3.10.18-1-root-build/usr/sbin/* File not found: /var/tmp/apcupsd-3.10.18-1-root-build/etc/apcupsd/apcupsd.css * cgi package missing %defattr Good: * name of package and spec * license (GPL) * code, not content * chkconfig script * macro usage I ran into the same problem building on FC-4/x86. However, the package builds fine in mock on both FC-3/x86 and FC-4/x86. I couldn't track down the source of this difference before running out of the time I had. I can't reproduce the build problem here. Are you sure that there aren't any other errors, say in compiling src/drivers/drivers.c which defines "attach_driver". I also don't get the "File not found" messages. To reproduce: fedora-rmdevelrpms yum install glibc-devel gd-devel dos2unix rpmbuild --rebuild apcupsd-3.10.18-1.src.rpm Unclear why mock works. Still can't reproduce. Can you send me the output of rpmbuild? Created attachment 120450 [details]
rpmbuild log
rpmbuild log
(In reply to comment #6) > rpmbuild log Can you try building without %{?_smp_mflags} passed to make? Works now without %{?_smp_mflags}, so please remove them. rpmlint says: W: apcupsd no-reload-entry /etc/rc.d/init.d/apcupsd W: apcupsd service-default-enabled /etc/rc.d/init.d/apcupsd W: apcupsd-cgi no-documentation W: apcupsd-cgi non-conffile-in-etc /etc/apcupsd/apcupsd.css Change the init script so it doesn't start by default. And mark that css file as a config file if it indeed is one. Need to Require chkconfig Source0 URL doesn't exist. You probably want http://download.sourceforge.net/apcupsd/apcupsd-3.10.18.tar.gz, which does match. The following looks good - package meets packaging guidelines - spec file legible - package compiles on FC4 i386 - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file (In reply to comment #8) > Works now without %{?_smp_mflags}, so please remove them. Done. > rpmlint says: > W: apcupsd no-reload-entry /etc/rc.d/init.d/apcupsd > W: apcupsd service-default-enabled /etc/rc.d/init.d/apcupsd > W: apcupsd-cgi no-documentation > W: apcupsd-cgi non-conffile-in-etc /etc/apcupsd/apcupsd.css > > Change the init script so it doesn't start by default. And mark that css file as > a config file if it indeed is one. Done. > Need to Require chkconfig Done. > Source0 URL doesn't exist. You probably want > http://download.sourceforge.net/apcupsd/apcupsd-3.10.18.tar.gz, which does match. Thanks, done. -3 released: http://www.cora.nwra.com/~orion/fedora/apcupsd-3.10.18-3.src.rpm Couldn't test it, no APC here, but the cgi monitor page displayed, at least. Don't include README.solaris, but this isn't a blocker. APPROVED Checked in a builds on devel. Package Change Request ====================== Package Name: apcupsd New Branches: EL-4 EL-5 Package Change Request ====================== Package Name: apcupsd Initial CC: apcupsd-users.net Please add apcupsd-users.net to the initial CC list. See http://sourceforge.net/mailarchive/message.php?msg_name=46859002.9070607%40cora.nwra.com for more info. apcupsd-users.net doesn't have a Bugzilla account. Please create a Bugzilla account for that address before we can add it. (In reply to comment #14) > apcupsd-users.net doesn't have a Bugzilla account. Please > create a Bugzilla account for that address before we can add it. Done. Thanks. CC added. |