Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166254
Summary: | Review Request: perl-Imager | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Gavin Henry <ghenry> | ||||
Component: | Package Review | Assignee: | Jef Spaleta <jspaleta> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | alex, ddick, fedora-extras-list, rc040203, steve | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
URL: | http://search.cpan.org/dist/Imager/ | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2006-03-16 00:18:16 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 163779 | ||||||
Attachments: |
|
Description
Gavin Henry
2005-08-18 11:34:42 UTC
built on against a rawhide box, rpmlint perl-Imager-0.45-1.i386.rpm: W: perl-Imager unstripped-binary-or-object /usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/auto/Imager/Imager.so ->Ignorable warning E: perl-Imager wrong-script-interpreter /usr/share/doc/perl-Imager-0.45/samples/anaglyph.pl "perl" E: perl-Imager wrong-script-interpreter /usr/share/doc/perl-Imager-0.45/samples/interleave.pl "perl" ->Can you patch the sample scripts in the samples directory to use #!/usr/bin/perl -w instead of #!perl -w and should they be executable? E: perl-Imager wrong-script-interpreter /usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/Imager/Font/Wrap.pm "perl" E: perl-Imager non-executable-script /usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/Imager/Font/Wrap.pm 0644 ->Same issue. Wrap.pm is the only pm file in the Font subdirectory that has an interpreter defined in the header. Either this needs to be corrected like the sample scripts or the interpreter line should be removed. I'm not sure which workaround is correct for Wrap.pm. Is it meant to be run as a stand-alone executable script? -jef additionally you'll need to clean up the same problems with this package as you had with perl-Apache-LogRegex - just use %check - remove the buildrequires on perl - need to include the license text in the docs section for the package. I haven't made it through the full review of this yet.. but i just want to make you aware that the same minor problems exist here. Most likely the other two pending perl packages for sprog deps have the same easy to fix issues too, so its a good idea to check over those packages as well for these 3 items. -jef I'll get this done next week. Looks like your need to apply %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" for this package to, as discussed for the other sprog deps so far. -jef I'm attaching a patch to the spec file that eliminates just about every issue I can find (including the more-or-less bogus warnings from rpmlint). I'll verify it with a mock build later today. Created attachment 118219 [details]
spec file fixes
Remove explicit perl BuildRequires.
BuildRequires: perl(Parse::RecDescent) (not perl-Parse-RecDescent).
BuildRequires: t1lib-devel.
Various things to quiet rpmlint.
Pass OPTIMIZE to Makefile.PL.
"%check" not "%check || :".
Include COPYING and Artistic.
Well, looks like people are being impatient ;-) I was going to knock Sprog and all these RPMs off my list tomorrow and Wednesday. I'll apply the patch/ Cheers, Gavin. Applied Steven Pritchard's patch New version: http://www.perl.me.uk/downloads/modules/perl-Imager-0.45-2.src.rpm http://www.perl.me.uk/downloads/modules/perl-Imager.spec http://www.perl.me.uk/downloads/modules/md5sums Okay let me go through the full review now. builds in mock for fedora development on x86. *naming is good *perl specific spec file conventions are being used *license tag matches the wording in the readme *readme with licensing terms include in docs *md5sum of sources match upstream *rpmlint returns clean *buildrequires look good, all the supprted image and font support appears to be included at build time according to the build log. *no locale files to worry about *no shared libraries in the linker path *created directory ownership is good *clean section good *no pre/post scriptlets *no static libs *files section looks good *no executables installed *no executables in docs section *rpmbuild --rebuild --target i686 works *sample scripts appear to work.. no errors or segfaults. Okay this looks good to me. I'll start the clock on this. I'll wait 24 hour before approving this in case someone finds a blocker. -jef It's been >24 hours Jef. ;-) approved Since this has been built in development, this bug should be CLOSED as NEXTRELEASE. (However I had troubles rebuilding this in development similar to what happens in bug #182459 for FC-4). Ping? Any idea why this hasn't been closed yet? *** Bug 665331 has been marked as a duplicate of this bug. *** *** Bug 1076745 has been marked as a duplicate of this bug. *** |