Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166555
Summary: | Review Request: orange - Squeeze out installable Microsoft cabinet files | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Andreas Bierfert <andreas.bierfert> |
Component: | Package Review | Assignee: | Christian Iseli <Christian.Iseli> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://synce.sourceforge.net/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-11-25 07:20:58 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 166553, 166554 | ||
Bug Blocks: | 163779 |
Description
Andreas Bierfert
2005-08-23 09:59:33 UTC
You have a BR for libole2-devel which I (and mock) can't seem to find. Any word of advice ? hm... [12:39 AM][awjb@alkaid ~]$ rpm -q libole2-devel libole2-devel-0.2.4-8.1 [12:39 AM][awjb@alkaid ~]$ rpm -qi libole2-devel Name : libole2-devel Relocations: (not relocatable) Version : 0.2.4 Vendor: Red Hat, Inc. Release : 8.1 Build Date: Thu 04 Mar 2004 04:04:01 PM CET Install Date: Tue 14 Sep 2004 11:44:09 AM CEST Build Host: porky.devel.redhat.com Group : Development/Libraries Source RPM: libole2-0.2.4-8.1.src.rpm Size : 73648 License: GPL Signature : DSA/SHA1, Fri 07 May 2004 12:23:27 AM CEST, Key ID b44269d04f2a6fd2 Packager : Red Hat, Inc. <http://bugzilla.redhat.com/bugzilla> Summary : Files needed for development of libole2 applications. Description : The libole2-devel package contains libraries, include files, etc., for developing libole2 applications. (In reply to comment #2) > Release : 8.1 Build Date: Thu 04 Mar 2004 04:04:01 PM CET > Install Date: Tue 14 Sep 2004 11:44:09 AM CEST Looks like you are using an older FC release. It appears libole2 is no longer present in FC 4: cig-245_root$ yum list \*ole2\* Setting up repositories livna 100% |=========================| 951 B 00:00 updates-released 100% |=========================| 951 B 00:00 extras 100% |=========================| 1.1 kB 00:00 base 100% |=========================| 1.1 kB 00:00 Reading repository metadata in from local files cig-245_root$ cat /etc/issue Fedora Core release 4 (Stentz) Kernel \r on an \m Here is an updated Spec and SRPM which depend on #169352. Sorry for the delay. http://fedora.lowlatency.de/review/orange-0.3-2.src.rpm http://fedora.lowlatency.de/review/orange.spec (In reply to comment #4) > Here is an updated Spec and SRPM which depend on #169352. Sorry for the delay. > > http://fedora.lowlatency.de/review/orange-0.3-2.src.rpm > http://fedora.lowlatency.de/review/orange.spec Well, it seems that upstream has put in some bit to allow the use of libgsf instead of the old libole2. I took the liberty do grab a CVS snapshot and try that in your package. Results are here: ftp://ftp.licr.org/pub/software/unix/orange.spec ftp://ftp.licr.org/pub/software/unix/orange-0.3cvs-0.src.rpm Have a look... I have not attempted to run the resulting executable (yet). Thanks :) sounds and looks good to me :)... so how do we proceede... ? Do you want to take over or should I just add your stuff to my version? (In reply to comment #6) > Thanks :) np > sounds and looks good to me :)... so how do we proceede... ? Do you > want to take over or should I just add your stuff to my version? Well, since you started it, why don't you just update it and then I'll review... http://fedora.lowlatency.de/review/orange-0.3cvs-0.src.rpm http://fedora.lowlatency.de/review/orange.spec Good: - rpmlint is ok - name ok - spec name ok - packaging guidelines met - license ok - license matches actual license in package - license file in %doc - spec file in American English and legible - source ok (CVS) - builds, installs, runs, and uninstalls cleanly - BuildRequires ok - no locale to worry about - shared libs ok - no relocation to worry about - no duplicated files - files perms ok - clean section ok - macro useage ok - package contains code - no large doc - %doc is only doc - builds in mock Nit: I'm not completely sure if there is a definitive policy regarding packages built from CVS snapshots, but looking around I think the spec file would be better with the small attached patch applied. Problem: It looks like the magic code to detect executable files is not quite up to snuff. It seems better with the attached patch. I'll approve it, if you agree with the patch. Cheers, Christian --- orange.spec.orig 2005-11-18 10:16:13.000000000 +0100 +++ orange.spec 2005-11-18 15:58:15.000000000 +0100 @@ -1,12 +1,15 @@ Name: orange -Version: 0.3cvs -Release: 0 +Version: 0.3 +Release: 0.cvs20051118%{?dist} Summary: Squeeze out installable Microsoft cabinet files Group: Applications/Communications License: MIT URL: http://synce.sourceforge.net/ Source0: orange-CVS-20051118.tar.gz +# Obtained through: +# cvs -z3 -d:pserver:anonymous.net:/cvsroot/synce co -P orange +Patch0: orange-chris.patch BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildRequires: synce-devel @@ -32,6 +35,7 @@ The %{name}-devel package contains the f %prep %setup -q -n orange +%patch0 -p1 -b .chris %build ./bootstrap @@ -67,6 +71,9 @@ rm -rf $RPM_BUILD_ROOT %{_includedir}/liborange.h %changelog +* Fri Nov 18 2005 Christian Iseli <Christian.Iseli[AT]licr.org> 0.3-0 +- grab latest from CVS to use libgsf instead of obsolete libole2 + * Tue Sep 27 2005 Andreas Bierfert <andreas.bierfert[AT]lowlatency.de> - include patch for new libole2 --- orange/lib/squeeze.c.chris 2005-11-18 15:56:56.000000000 +0100 +++ orange/lib/squeeze.c 2005-11-18 15:56:16.000000000 +0100 @@ -226,7 +226,7 @@ synce_trace("Found MSI format."); } #endif - else if (strstr(description, "MS-DOS executable (EXE), OS/2 or MS Windows")) + else if (strstr(description, " executable ")) { success = squeeze_exe(filename, output_directory); } Sure I do agree :) here is an updated package =) (sorry for the elapsed time) http://fedora.lowlatency.de/review/orange-0.3-0.cvs20051118.src.rpm http://fedora.lowlatency.de/review/orange.spec np :) Approved. Please also close the libole2 review request. imported and build... Thanks for the patience and the review :) |