Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at

Bug 166555

Summary: Review Request: orange - Squeeze out installable Microsoft cabinet files
Product: [Fedora] Fedora Reporter: Andreas Bierfert <andreas.bierfert>
Component: Package ReviewAssignee: Christian Iseli <Christian.Iseli>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-extras-list
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-11-25 07:20:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 166553, 166554    
Bug Blocks: 163779    

Description Andreas Bierfert 2005-08-23 09:59:33 UTC
Spec Name or Url:
SRPM Name or Url:
Orange is a tool and library for squeezing out juicy installable Microsoft
Cabinet Files from self-extracting installers for Microsoft Windows and some
other installer file formats

Comment 1 Christian Iseli 2005-09-16 16:59:28 UTC
You have a BR for libole2-devel which I (and mock) can't seem to find.
Any word of advice ?

Comment 2 Andreas Bierfert 2005-09-16 22:39:44 UTC

[12:39 AM][awjb@alkaid ~]$ rpm -q libole2-devel
[12:39 AM][awjb@alkaid ~]$ rpm -qi libole2-devel
Name        : libole2-devel                Relocations: (not relocatable)
Version     : 0.2.4                             Vendor: Red Hat, Inc.
Release     : 8.1                           Build Date: Thu 04 Mar 2004 04:04:01
Install Date: Tue 14 Sep 2004 11:44:09 AM CEST      Build Host:
Group       : Development/Libraries         Source RPM: libole2-0.2.4-8.1.src.rpm
Size        : 73648                            License: GPL
Signature   : DSA/SHA1, Fri 07 May 2004 12:23:27 AM CEST, Key ID b44269d04f2a6fd2
Packager    : Red Hat, Inc. <>
Summary     : Files needed for development of libole2 applications.
Description :
The libole2-devel package contains libraries, include files, etc., for
developing libole2 applications.

Comment 3 Christian Iseli 2005-09-16 23:06:29 UTC
(In reply to comment #2)
> Release     : 8.1                Build Date: Thu 04 Mar 2004 04:04:01 PM CET
> Install Date: Tue 14 Sep 2004 11:44:09 AM CEST

Looks like you are using an older FC release.  It appears libole2 is no longer
present in FC 4:

cig-245_root$ yum list \*ole2\*
Setting up repositories
livna                     100% |=========================|  951 B    00:00
updates-released          100% |=========================|  951 B    00:00
extras                    100% |=========================| 1.1 kB    00:00
base                      100% |=========================| 1.1 kB    00:00
Reading repository metadata in from local files

cig-245_root$ cat /etc/issue
Fedora Core release 4 (Stentz)
Kernel \r on an \m

Comment 4 Andreas Bierfert 2005-09-27 13:22:45 UTC
Here is an updated Spec and SRPM which depend on #169352. Sorry for the delay.

Comment 5 Christian Iseli 2005-11-18 09:21:16 UTC
(In reply to comment #4)
> Here is an updated Spec and SRPM which depend on #169352. Sorry for the delay.

Well, it seems that upstream has put in some bit to allow the use of libgsf
instead of the old libole2.  I took the liberty do grab a CVS snapshot and
try that in your package.  Results are here:

Have a look...  I have not attempted to run the resulting executable (yet).

Comment 6 Andreas Bierfert 2005-11-18 09:28:15 UTC
Thanks :) sounds and looks good to me :)... so how do we proceede... ? Do you
want to take over or should I just add your stuff to my version?

Comment 7 Christian Iseli 2005-11-18 10:39:21 UTC
(In reply to comment #6)
> Thanks :)


> sounds and looks good to me :)... so how do we proceede... ? Do you
> want to take over or should I just add your stuff to my version?

Well, since you started it, why don't you just update it and then I'll review...

Comment 9 Christian Iseli 2005-11-18 15:08:49 UTC
- rpmlint is ok
- name ok
- spec name ok
- packaging guidelines met
- license ok
- license matches actual license in package
- license file in %doc
- spec file in American English and legible
- source ok (CVS)
- builds, installs, runs, and uninstalls cleanly
- BuildRequires ok
- no locale to worry about
- shared libs ok
- no relocation to worry about
- no duplicated files
- files perms ok
- clean section ok
- macro useage ok
- package contains code
- no large doc
- %doc is only doc
- builds in mock

I'm not completely sure if there is a definitive policy regarding packages
built from CVS snapshots, but looking around I think the spec file would be
better with the small attached patch applied.

It looks like the magic code to detect executable files is not quite up to
snuff.  It seems better with the attached patch.

I'll approve it, if you agree with the patch.


--- orange.spec.orig    2005-11-18 10:16:13.000000000 +0100
+++ orange.spec 2005-11-18 15:58:15.000000000 +0100
@@ -1,12 +1,15 @@
 Name:           orange
-Version:        0.3cvs
-Release:        0
+Version:        0.3
+Release:        0.cvs20051118%{?dist}
 Summary:        Squeeze out installable Microsoft cabinet files

 Group:          Applications/Communications
 License:        MIT
 Source0:        orange-CVS-20051118.tar.gz
+# Obtained through:
+# cvs -z3 co -P orange
+Patch0:         orange-chris.patch
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

 BuildRequires:  synce-devel
@@ -32,6 +35,7 @@ The %{name}-devel package contains the f

 %setup -q -n orange
+%patch0 -p1 -b .chris

@@ -67,6 +71,9 @@ rm -rf $RPM_BUILD_ROOT

+* Fri Nov 18 2005 Christian Iseli <Christian.Iseli[AT]> 0.3-0
+- grab latest from CVS to use libgsf instead of obsolete libole2
 * Tue Sep 27 2005 Andreas Bierfert <andreas.bierfert[AT]>
 - include patch for new libole2

--- orange/lib/squeeze.c.chris  2005-11-18 15:56:56.000000000 +0100
+++ orange/lib/squeeze.c        2005-11-18 15:56:16.000000000 +0100
@@ -226,7 +226,7 @@
       synce_trace("Found MSI format.");
-  else if (strstr(description, "MS-DOS executable (EXE), OS/2 or MS Windows"))
+  else if (strstr(description, " executable "))
     success = squeeze_exe(filename, output_directory);

Comment 10 Andreas Bierfert 2005-11-24 20:08:50 UTC
Sure  I do agree :) here is an updated package =) (sorry for the elapsed time)

Comment 11 Christian Iseli 2005-11-24 21:52:45 UTC
np :)


Please also close the libole2 review request.

Comment 12 Andreas Bierfert 2005-11-25 07:20:58 UTC
imported and build...

Thanks for the patience and the review :)