Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166835
| Summary: | Review Request: perl-SNMP_Session - Pure Perl SNMP v1 and SNMP v2 support | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jose Pedro Oliveira <jose.p.oliveira.oss> |
| Component: | Package Review | Assignee: | Paul Howarth <paul> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.switch.ch/misc/leinen/snmp/perl/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-09-14 12:33:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Jose Pedro Oliveira
2005-08-26 10:56:43 UTC
Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is Artistic, matches spec, text included - spec written in English and is legible - sources match upstream - packages builds OK on FC4 and in mock for rawhide (i386) - no explicit BR's needed - no locales, libraries, subpackages or pkgconfigs to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets - no .desktop file needed Nitpick: - redundant BR: perl - given that "make test" does nothing, it would be nice if someone with SNMP-enabled kit could try out some of the test scripts to make sure that things work properly... I'll approve the package but please lose the BR: perl in cvs. Paul, (In reply to comment #1) > Nitpick: > > - redundant BR: perl I will remove it. > - given that "make test" does nothing, it would be nice if someone with > SNMP-enabled kit could try out some of the test scripts to make sure that > things work properly... Last year I used this module in two perl daemons: i) a trap deamon decoded traps using this module logged information using Log::Log4perl(Log::Dispatch) used a MySQL db via DBI/DBD::mysql 2) a query daemon to handle snmp_set and snmp_get requests of a web application > > I'll approve the package but please lose the BR: perl in cvs. Can I consider this perl module approved? PS - One of the example scripts uses Curses. I have it packaged if someone wants it. (In reply to comment #2) > (In reply to comment #1) > > Nitpick: > > > > - redundant BR: perl > > I will remove it. Thanks. > > - given that "make test" does nothing, it would be nice if someone with > > SNMP-enabled kit could try out some of the test scripts to make sure that > > things work properly... > > Last year I used this module in two perl daemons: > i) a trap deamon > decoded traps using this module > logged information using Log::Log4perl(Log::Dispatch) > used a MySQL db via DBI/DBD::mysql > 2) a query daemon > to handle snmp_set and snmp_get requests of a web application Thanks again. > > I'll approve the package but please lose the BR: perl in cvs. > > Can I consider this perl module approved? Already approved (blocker changed to FE-ACCEPT). > PS - One of the example scripts uses Curses. I have it packaged if someone > wants it. Might be worth mentioning on extras list (not sure how many people read the bugzilla traffic). (In reply to comment #3) > > > I'll approve the package but please lose the BR: perl in cvs. > > > > Can I consider this perl module approved? > > Already approved (blocker changed to FE-ACCEPT). Missed that (viewing too many bugzilla tickets at the same time). > > > PS - One of the example scripts uses Curses. I have it packaged if someone > > wants it. > > Might be worth mentioning on extras list (not sure how many people read the > bugzilla traffic). I will announced it in the fedora-extras or in the fedora-perl-devel mailing list but I will postpone it a couple of days (trying to push every RT perl requirements first). |