Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 167377
Summary: | Review Request: perl-Class-Singleton | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Steven Pritchard <steve> |
Component: | Package Review | Assignee: | Paul Howarth <paul> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://ftp.kspei.com/pub/steve/rpms/perl-Class-Singleton-1.03-1.src.rpm | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-09-08 16:37:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 167376 |
Description
Steven Pritchard
2005-09-02 00:43:41 UTC
Review: - package and spec naming OK - package meets guidelines - license is Artistic, matches spec, text included - spec file written in English and is legible - source matches upstream - builds OK in mock for FC4 and rawhide (i386) - no BRs - no locales, libraries, subpackages or pkgconfigs to worry about - not relocatable - no directory ownership issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets Needswork: - rpmlint not clean: E: perl-Class-Singleton script-without-shellbang /usr/lib/perl5/vendor_perl/5.8.6/Class/Singleton.pm This script does not begins with a shellbang. It will prevent its execution. This is due to the exec bit being set on Singleton.pm in the upstream tarball, and this permission is preserved at install-time. It can be fixed by adding after %setup: chmod -x Singleton.pm You can fix that in CVS. Approved. Fixed in 1.03-2. Package Change Request ====================== Package Name: perl-Class-Singleton New Branches: el6 Owners: steve InitialCC: perl-sig Nevermind. It's in the optional repo. |