Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 167545

Summary:	Review Request: wlassistant : Wireless network management tool
Product:	[Fedora] Fedora	Reporter:	Tom "spot" Callaway <tcallawa>
Component:	Package Review	Assignee:	José Matos <jamatos>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://wlassistant.sourceforge.net
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-09-13 17:38:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Tom "spot" Callaway 2005-09-05 01:17:20 UTC

Spec Name or Url: http://www.auroralinux.org/people/spot/review/wlassistant.spec
SRPM Name or Url: http://www.auroralinux.org/people/spot/review/wlassistant-0.5.4a-1.src.rpm
Description:
Wireless Assistant (wlassistant) is a small application that allows you to
connect to wireless networks.

MAIN FEATURES:
- Managed Networks Support
- WEP Encryption Support
- Not Broadcasted ("hidden") ESSIDs Support
- Per Network (AP) Configuration Profiles
- Automatic (DHCP, both dhcpcd and dhclient) and manual configuration options.

Comment 1 José Matos 2005-09-09 15:28:19 UTC

Build fails in mock for x86_64.

Comment 2 José Matos 2005-09-09 15:30:59 UTC

The package should use BR wireless-tools or else the compilation will fail.

Comment 3 José Matos 2005-09-13 17:38:47 UTC

Assuming that wireless-tools are used as BuildRequires I get:  
  
+ mock build fine on x86_64  
+ rpmlint:  
rpmlint *.rpm  
W: wlassistant no-dependency-on usermode-consoleonly  
W: wlassistant  
symlink-should-be-relative /usr/sbin/wlassistant /usr/bin/consolehelper  
  
The later can be IMHO ignored.  
  
+ license is correct, matches upstream and is included in the package  
+ source match upstreams  
+ the spec file is legible and written in American English  
+ name OK  
+ Requires OK  
+ %lang OK  
+ no libraries 
+ desktop files OK 
+ %doc OK 
+ no need for devel 
 
The package is Approved assuming that you add the missing BR. I guess that I 
will trust you here. ;-)