Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 167889
Summary: | Review Request: polyxmass-data - Contains configuration files describing polymer chemistry | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Andreas Bierfert <andreas.bierfert> |
Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.polyxmass.org | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-10-26 06:36:21 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 167887 | ||
Bug Blocks: | 163779 |
Description
Andreas Bierfert
2005-09-09 07:56:28 UTC
This data is necessary for polyxmass to be useful, so it is acceptable data - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc - spec file legible - source matches upstream - package compiles on FC4 i386 - no BR - no locales - not relocatable - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file needs work: - does not appear to own or require /usr/share/polyxmass - rpmlint: W: polyxmass-data non-conffile-in-etc /etc/polyxmass/polchem-defs/polyxmass-data-polchem-defs-cat W: polyxmass-data non-conffile-in-etc /etc/polyxmass/polchem-defs/polyxmass-data-polchem-defs-atom-defs-dic and a while lot of zero length .ogg files. Are the oggs necessary? The conffile can probably be ignored, it's really a config file. Hm I don't know about the .ogg files but /usr/share/polyxmass is owned by polyxmass-bin and thus ok because polyxmass-data requires polyxmass-bin... =) OK, polyxmass-bin owns /usr/share/polyxmass. And the zero length isn't a big deal. APPROVED Now waiting on polyxmass-bin. (In reply to comment #1) > This data is necessary for polyxmass to be useful, so it is acceptable data > > - package meets naming guidelines > - package meets packaging guidelines > - license (GPL) OK, text in %doc > - spec file legible > - source matches upstream > - package compiles on FC4 i386 > - no BR > - no locales > - not relocatable > - no duplicate files > - permissions ok > - %clean ok > - macro use consistent > - code, not content > - no need for -docs > - nothing in %doc affects runtime > - no need for .desktop file > > needs work: > - does not appear to own or require /usr/share/polyxmass > - rpmlint: > W: polyxmass-data non-conffile-in-etc > /etc/polyxmass/polchem-defs/polyxmass-data-polchem-defs-cat > W: polyxmass-data non-conffile-in-etc > /etc/polyxmass/polchem-defs/polyxmass-data-polchem-defs-atom-defs-dic > > and a while lot of zero length .ogg files. Are the oggs necessary? The conffile > can probably be ignored, it's really a config file. If the files in /etc/polyxmass really are config files, perhaps then they should be marked as such? %config %{_sysconfdir}/polyxmass/polchem-defs* or %config(noreplace) %{_sysconfdir}/polyxmass/polchem-defs/* I have been thinking about this for some time and while these are definitions used by the program I don't think they are config files in the rpm sense that comes to mind when thinking about %config. (In reply to comment #5) > I have been thinking about this for some time and while these are definitions > used by the program I don't think they are config files in the rpm sense that > comes to mind when thinking about %config. Perhaps a better location for them would be %{_datadir}/polyxmass rather than %{_sysconfdir}/polyxmass then? Is that feasible? Hm... I guess leaving them and marking them as %config is the best way to go after all if this is ok with you... Build for fc{3,4,5} Thanks for the review :) |