Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 168046
| Summary: | Review Request: pyflowtools - An interface to OSU FlowTools | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paul P Komkoff Jr <i> | ||||
| Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-extras-list | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | http://www.net.informatik.tu-muenchen.de/pers/robin/flowtools/ | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2005-10-07 12:41:25 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 163779 | ||||||
| Attachments: |
|
||||||
|
Description
Paul P Komkoff Jr
2005-09-11 16:17:20 UTC
Anything special here? Spec Name or Url: http://mirrors.sgu.ru/mm/s/SPECS/pyflowtools.spec SRPM Name or Url: http://mirrors.sgu.ru/mm/s/4/SRPMS/pyflowtools-0.3-3.src.rpm I've updated .spec and SRPM. May we approve it and move on to the next package? I have many of them almost ready ... Spot? Good: - rpmlint checks return: W: pyflowtools wrong-file-end-of-line-encoding /usr/share/doc/pyflowtools-0.3/COPYING - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Created attachment 119647 [details]
minor cleanups for pyflowtools spec file
There is one issue that I think is worth mentioning with this package. You're
using a generated filelist and using that to populate %files. This is not a
terribly safe way to do things, because it will not own directories that are
created.
In the case of pyflowtools, no new directories are created, and the result is
the same, but its never too early to break bad habits.
This package is APPROVED, but please make the spec file changes as listed in
this patch before requesting a build.
APPROVED. Also, in the future, if you want to get my attention faster, please either send me an email or CC me on the bug. :) This actually breaks on x86_64: [stingray@ns SPECS]$ arch ; python -c "from distutils.sysconfig import get_python_lib; print get_python_lib()" x86_64 /usr/lib/python2.4/site-packages Try:
%{__python} -c "from distutils.sysconfig import get_python_lib; print
get_python_lib(1)"
instead
|