Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 168070

Summary:	Review request: perl-Mail-GnuPG - Process email with GPG
Product:	[Fedora] Fedora	Reporter:	Ralf Corsepius <rc040203>
Component:	Package Review	Assignee:	Tom "spot" Callaway <tcallawa>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/Mail-GnuPG/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-10-06 16:19:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	166713
Bug Blocks:	163779, 169247

Description Ralf Corsepius 2005-09-12 05:02:02 UTC

Spec Name or Url:
ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Mail-GnuPG.spec

SRPM Name or Url:
ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Mail-GnuPG-0.08-2.src.rpm

Description:
Use GnuPG::Interface to process or create PGP signed or encrypted email.

Comment 1 Ralf Corsepius 2005-09-12 05:04:43 UTC

This is a dependency of rt3

Comment 2 Tom "spot" Callaway 2005-10-05 18:10:46 UTC

Warning: prerequisite MIME::Entity 0 not found.
Warning: prerequisite MIME::Parser 0 not found.
Warning: prerequisite Mail::Address 0 not found.

These come from perl-MailTools and perl-Mime-tools. You can resolve this by adding:

BuildRequires: perl(MIME::Entity), perl(MIME::Parser), perl(Mail::Address)

Review (with above change made):
Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL or Artistic) OK, links to license text in README, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED (with BR change)