Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 168173

Summary:	Review request: perl-Class-Inspector - Get information about a class and its structure
Product:	[Fedora] Fedora	Reporter:	Ralf Corsepius <rc040203>
Component:	Package Review	Assignee:	Paul Howarth <paul>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/Class-Inspector/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-09-13 16:32:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 168174

Description Ralf Corsepius 2005-09-13 07:56:57 UTC

Spec Name or Url:
ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Class-Inspector.spec

SRPM Name or Url:
ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Class-Inspector-1.12-1.src.rpm

Description:
Class::Inspector allows you to get information about a loaded class.
Most or all of this information can be found in other ways, but they aren't
always very friendly, and usually involve a relatively high level of Perl
wizardry, or strange and unusual looking code. Class::Inspector attempts to
provide an easier, more friendly interface to this information.

Comment 1 Paul Howarth 2005-09-13 10:36:21 UTC

Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec, text included
- spec file written in English and is legible
- sources match upstream
- package builds OK on FC4 and in mock for rawhide (i386)
- BR's OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets
- no .desktop file needed

Nitpick:

- summary should read:
  Get information about a class and its structure
  rather than:
  Get information about a class and it's structur

  please fix in cvs.

Approved.