Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 168213
Summary: | Review request: perl-Test-Inline - Test::Inline Perl module | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ralf Corsepius <rc040203> | ||||
Component: | Package Review | Assignee: | Paul Howarth <paul> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | fedora-extras-list, lkundrak | ||||
Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
URL: | http://search.cpan.org/dist/Test-Inline/ | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2005-10-11 01:46:25 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 167282, 168174, 168175, 168178, 168187, 168298, 169112 | ||||||
Bug Blocks: | 163779, 169247 | ||||||
Attachments: |
|
Description
Ralf Corsepius
2005-09-13 15:48:19 UTC
Damn it! New version released yesterday. Diff: http://search.cpan.org/diff?from=Test-Inline-2.100&to=Test-Inline-2.101 Most interesting detail of this diff: build_requires ( 'Test::More' => '0.47' ); build_requires ( 'Test::ClassAPI' => '1.02' ); -include ( 'ExtUtils::AutoInstall' ); include ( 'Test::ClassAPI' ); => Not unlikely ExtUtils::AutoInstall has become superfluous (at least here) I'll try to provide an updated package ASAP. Yes, the dep on ExtUtils is gone in this case, but a new one on Param::Util has appeared. New package/spec to appear at: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Test-Inline.spec ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Test-Inline-2.101-1.src.rpm Yet another upstream update: New package/spec at: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Test-Inline.spec ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Test-Inline-2.102-1.src.rpm ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Test-Inline.spec ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Test-Inline-2.103-1.src.rpm Meanwhile, all package dependencies of this package have been resolved. I would really appreciate it, if somebody would consider to review this package. I'm back, after taking it easy for a couple of weeks due to the birth of my first child... Review: - rpmlint nearly clean, see below - package and spec file naming OK - package meets guidelines - license is same as perl, matches spec, text included - spec file written in English and is legible - sources match upstream - package builds OK in mock on FC4 (i386) - BR's OK; long list of versioned dependencies matches Makefile.PL - no locales, libraries, subpackages or pkgconfigs to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no .desktop file needed - no scriptlets Nitpick: - a couple of typos/comment changes: "# 2.100 - 2.102 ship with executable Changes" still applies to 2.103 changelog entry "Add filter-requires to filter bogus perl(strict)" should refer to perl(script), not perl(strict) - add BR: perl(Test::Pod) for extra test coverage Notes: = rpmlint output: W: perl-Test-Inline strange-permission perl-Test-Inline-filter-requires.sh 0755 script needs to be executable in SRPM or it won't work, so this is OK. - the filter-requires script is used to filter out the bogus perl(script) dependency originating from Test/Inline/Content.pm Approved. Created attachment 119702 [details]
Patch addressing review issues
Package Change Request ====================== Package Name: perl-Test-Inline New Branches: epel7 Owners: lkundrak The Fedora maintainer (Ralf Corsepius, corsepiu) is not willing to maintain EPEL packages. Git done (by process-git-requests). |