Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 168523

Summary:	Review Request: perl-Text-Diff
Product:	[Fedora] Fedora	Reporter:	Steven Pritchard <steve>
Component:	Package Review	Assignee:	Aurelien Bompard <gauret>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/Text-Diff/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-01-07 00:21:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Steven Pritchard 2005-09-16 21:10:15 UTC

Spec Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Text-Diff/perl-Text-Diff.spec
SRPM Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Text-Diff-0.35-2.src.rpm
Description:
Text::Diff - Perform diffs on files and record sets.

Comment 1 Aurelien Bompard 2005-09-27 12:32:21 UTC

Review for release 2:
* RPM name is OK
* Source Text-Diff-0.35.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of perl-Text-Diff looks OK
* File list of perl-Text-Diff looks OK
* Works fine

Possible improvements:
The fedora spec template for perl modules uses this in %build:
  CFLAGS="$RPM_OPT_FLAGS" %{__perl} Makefile.PL INSTALLDIRS=vendor
  make %{?_smp_mflags} OPTIMIZE="$RPM_OPT_FLAGS"
These optimizations could be added.

Comment 2 Ralf Corsepius 2005-09-27 13:11:53 UTC

(In reply to comment #1)

> The fedora spec template for perl modules uses this in %build:
>   CFLAGS="$RPM_OPT_FLAGS" %{__perl} Makefile.PL INSTALLDIRS=vendor
>   make %{?_smp_mflags} OPTIMIZE="$RPM_OPT_FLAGS"
> These optimizations could be added.
No, the perl template is broken. These flags are redundant.

%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
make %{?_smp_mflags}
is sufficient and correct in most cases

Comment 3 Jose Pedro Oliveira 2006-01-06 20:49:13 UTC

Steven,

Could you import and build this one?
It has already been approved several months ago.

jpo

Comment 4 Steven Pritchard 2006-01-06 21:18:34 UTC

Sorry, I didn't catch that this one was approved.

I'm importing it now...

Comment 5 Steven Pritchard 2010-12-07 19:50:09 UTC

Package Change Request
======================
Package Name: perl-Text-Diff
New Branches: el6
Owners: steve
InitialCC: perl-sig

Comment 6 Steven Pritchard 2010-12-08 13:56:33 UTC

Nevermind. It's in the optional repo.