Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 168583

Summary:	Review Request: perl-Crypt-DES_EDE3
Product:	[Fedora] Fedora	Reporter:	Steven Pritchard <steve>
Component:	Package Review	Assignee:	Paul Howarth <paul>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/Crypt-DES_EDE3/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-02-03 02:48:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	168580
Bug Blocks:	163779, 168607

Description Steven Pritchard 2005-09-17 15:36:24 UTC

Spec Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Crypt-DES_EDE3/perl-Crypt-DES_EDE3.spec
SRPM Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Crypt-DES_EDE3-0.01-2.src.rpm
Description: 
This is Crypt::DES_EDE3, a module implementing Triple-DES EDE
(encrypt-decrypt-encrypt) encryption and decryption.

Comment 1 Paul Howarth 2005-10-24 15:43:58 UTC

Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec, text generated and included
- spec file written in English and is legible
- sources match upstream
- package builds OK in mock for FC4 (i386)
- BR's OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no desktop entry needed
- no scriptlets

Suggestion:

- "Triple-DES EDE encryption/decryption module" might be a better summary than
  "Crypt::DES_EDE3 Perl module"

Approved.