Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 168607
Summary: | Review Request: perl-Convert-PEM | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Steven Pritchard <steve> |
Component: | Package Review | Assignee: | Paul Howarth <paul> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://search.cpan.org/dist/Convert-PEM/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-02-03 03:12:21 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 168578, 168583 | ||
Bug Blocks: | 163779, 174368 |
Description
Steven Pritchard
2005-09-17 21:28:47 UTC
Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, matches spec - license text included, though not directly from upstream - spec file written in English and is legible - sources match upstream - package builds OK in mock on FC4 (i386) - BR's OK - no locales, libraries, subpackages or pkgconfigs to worry about - not relocatable - no duplicate files - no permissions issues - %clean section present and correct - macro usage is consistent - code, not content - no large docs, docs don't affect runtime - no desktop entry needed - no scriptlets Nitpick: - files list should include: %{perl_vendorlib}/Convert/* rather than: %{perl_vendorlib}/* since the package depends on perl(Convert::ASN1), and the package containing that module owns the %{perl_vendorlib}/Convert directory Suggestions: - "Read/write encrypted ASN.1 PEM files" might be a better summary than "Convert::PEM Perl module" - You might want to skip the license texts since upstream doesn't provide them Approved (In reply to comment #1) > - files list should include: > %{perl_vendorlib}/Convert/* > rather than: > %{perl_vendorlib}/* > since the package depends on perl(Convert::ASN1), and the package containing > that module owns the %{perl_vendorlib}/Convert directory Wrong - We have had this discussion before. Both packages must own %{perl_vendorlib}/Convert because rpm does not assure any particular order during multilib packag removals, such as rpm -e '<all-packages owning %{perl_vendorlib}/Convert' (In reply to comment #2) > (In reply to comment #1) > > > - files list should include: > > %{perl_vendorlib}/Convert/* > > rather than: > > %{perl_vendorlib}/* > > since the package depends on perl(Convert::ASN1), and the package containing > > that module owns the %{perl_vendorlib}/Convert directory > Wrong - We have had this discussion before. > > Both packages must own %{perl_vendorlib}/Convert because rpm does not assure any > particular order during multilib packag removals, such as > rpm -e '<all-packages owning %{perl_vendorlib}/Convert' In that case I'd suggest that the sentence: If it does not create a directory that it uses, then it should require a package which does create that directory. be removed from the package review guidelines: http://fedoraproject.org/wiki/PackageReviewGuidelines I think Spot should be the one to do that though. Steve, can you do a build of this module for FC-4 please? I've been trying... http://buildsys.fedoraproject.org/build-status/job.psp?uid=3816 I wonder if hammer2 is having issues. I had another build fail on it yesterday that worked fine on my x86_64 system under mock. Scratch that. My other mystery failed build yesterday died on hammer3. (In reply to comment #5) > I've been trying... > > http://buildsys.fedoraproject.org/build-status/job.psp?uid=3816 > > I wonder if hammer2 is having issues. I had another build fail on it yesterday > that worked fine on my x86_64 system under mock. Could you give it another go, to see if it's one of those transient buildsystem issues? Sorry, I forgot about this. I requeued it, and it built this time. |