Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 168608
Summary: | Review Request: emelFM2 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christoph Wickert <cwickert> |
Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://emelfm2.org/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-09-29 14:02:32 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Christoph Wickert
2005-09-17 22:21:40 UTC
- Both patches contain hardcoded paths (/usr/share in patch0 and /usr in patch1). It has to be %{_datadir} and %{_prefix} respectively. You could for example use %DATADIR% and %PREFIX% in your patches and do sed substitution in %prep to set the right path. - In the specfile, you defined the patches names with %{version} included. It is going to cause trouble on the next package update. You'd better replace it with 0.1.2. - In %install, you use %{prefix}. It should be %{_prefix} (with underscore) - The package sould own %{_libdir}/%{name} and %{_datadir}/pixmaps/%{name} (In reply to comment #1) > - Both patches contain hardcoded paths (/usr/share in patch0 and /usr in > patch1). It has to be %{_datadir} and %{_prefix} respectively. You could for > example use %DATADIR% and %PREFIX% in your patches and do sed substitution in > %prep to set the right path. Thanks. Did that with prefix in Makefile.config. Removed broken-icon path using only sed instead. > - In the specfile, you defined the patches names with %{version} included. It is > going to cause trouble on the next package update. You'd better replace it with > 0.1.2. fixed > - In %install, you use %{prefix}. It should be %{_prefix} (with underscore) fixed > - The package sould own %{_libdir}/%{name} and %{_datadir}/pixmaps/%{name} fixed New SRPM: http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/emelfm2-0.1.2-2.fc4.src.rpm Updated SPEC: http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/emelfm2.spec Review for release 2.fc4: * RPM name is OK * Source emelfm2-0.1.2.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * rpmlint of emelfm2 looks OK * File list of emelfm2 looks OK * Works fine APPROVED Fixed an error on x86_64. New release is -3, has build fine on all plattforms. |