Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 168635
Summary: | Review Request: colorscheme: generate a variety of colorschemes from a single starting color | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Aurelien Bompard <gauret> |
Component: | Package Review | Assignee: | Toshio Kuratomi <toshio> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://home.gna.org/colorscheme/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-09-21 07:59:06 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Aurelien Bompard
2005-09-18 19:36:11 UTC
APPROVED But see Notes. b017737456db88209a405e26b81b6f64 colorscheme.spec 49ee1ae0b442054e1857a27d90591f6e colorscheme-0.2.1-1.src.rpm Good: * Package name follows namng guidelines. * spec is named after the package name. * License is GPL, matches the spec name, and is included in the package. * Spec file is legible * Builds on x86_64. * No ExcludeArchs yet. * No excluded BuildRequires. * Builds in mock * Matches upstream source * Owns all directories * No duplicate files * Permissions set correctly * Has %clean section * Makes good use of macros * Code not content * Properly contains a .desktop file. Minor: * rpmlint gives: W: colorscheme wrong-file-end-of-line-encoding /usr/share/doc/colorscheme-0.2.1/TODO This could be fixed with dos2unix, ignored, or the TODO file could be left out of the distribution. It isn't terribly useful. Notes: * colorscheme has its own unittests. These are enabled by buildrequiring cppunit-devel and running make check in the %check section. I tried to run the tests on the current package and found that quite a few of them failed. If this isn't known, you might want to run the tests and submit a bug upstream. * I don't believe there's a lot of value in including the .sig. A reviewer still has to go to the project website to verify the origin of the .sig and (most of the time) that the key seems to belong to the upstream author. The .sig should be checked by the reviewer but not included in the finished package. If you have/know of another view, feel free to share. > unittests I've added a "make check || :" in the rpm, and reported the failed tests upstream. > signature Agreed, if the sig is not signed by people you trust, it's as valuable as an MD5SUM. Removed. I'll import the package with these modifications. |