Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1686654

Summary:	firewalld does not run fully in current Rawhide after kickstart install ('modinfo command is missing', 'Failed to load nf_conntrack module')
Product:	[Fedora] Fedora	Reporter:	Adam Williamson <awilliam>
Component:	selinux-policy	Assignee:	Lukas Vrabec <lvrabec>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	high
Version:	rawhide	CC:	dwalsh, egarver, jpopelka, lvrabec, mgrepl, plautrba, twoerner, zpytela
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:	openqa
Fixed In Version:	selinux-policy-3.14.4-8.fc31	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-04-05 17:58:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1644937

Description Adam Williamson 2019-03-07 23:37:17 UTC

In Fedora-Rawhide-20190306.n.1, all firewall tests failed. There seem to be two separate bugs in two different tests. In this one, an install is run from the server DVD with a kickstart - http://fedorapeople.org/groups/qa/kickstarts/firewall-configured-net.ks - that says 'firewall --port=imap:tcp,1234:udp,47 --service=ftp' (and installs only '@core' packages). The install completes successfully, and the test then boots the installed system and runs 'firewall-cmd --state', expecting it to succeed (success indicates the firewall is running, failure indicates it is not). It fails, with the output 'not running'. Looking at the firewalld service logs, we see this:

Mar 06 17:22:51 localhost.localdomain systemd[1]: Starting firewalld - dynamic firewall daemon...
Mar 06 17:22:52 localhost.localdomain systemd[1]: Started firewalld - dynamic firewall daemon.
Mar 06 17:22:52 localhost.localdomain firewalld[578]: WARNING: modinfo command is missing, not able to detect conntrack helpers.
Mar 06 17:22:53 localhost.localdomain firewalld[578]: ERROR: Failed to load nf_conntrack module:
Mar 06 17:22:53 localhost.localdomain firewalld[578]: ERROR: Raising SystemExit in run_server
Mar 06 17:22:53 localhost.localdomain systemd[1]: firewalld.service: Succeeded.

I'm not sure if the lack of modinfo is the *cause* of the subsequent failure, I will do a manual test install and check it out.

Proposing as an F31 Beta blocker per "..Supported install-time firewall configuration options must work correctly." - https://fedoraproject.org/wiki/Basic_Release_Criteria#Firewall_configuration , this test is specifically meant to enforce that criterion. Will move to F30 if this also affects it, once we finally get a compose.

Comment 1 Eric Garver 2019-03-08 13:49:40 UTC

(In reply to Adam Williamson from comment #0)
...
> Mar 06 17:22:51 localhost.localdomain systemd[1]: Starting firewalld -
> dynamic firewall daemon...
> Mar 06 17:22:52 localhost.localdomain systemd[1]: Started firewalld -
> dynamic firewall daemon.
> Mar 06 17:22:52 localhost.localdomain firewalld[578]: WARNING: modinfo
> command is missing, not able to detect conntrack helpers.

This is non fatal which is why it's logged as a warning.

> Mar 06 17:22:53 localhost.localdomain firewalld[578]: ERROR: Failed to load
> nf_conntrack module:

This _is_ fatal. We can't do firewalling without the nf_conntrack kernel module.
Does it successfully load manually?

  # modprobe nf_conntrack

Comment 2 Adam Williamson 2019-03-08 16:51:27 UTC

I tried the same test locally to answer the question, but instead of this bug, it hit the other one - https://bugzilla.redhat.com/show_bug.cgi?id=1686660 . I'll try it another couple of times...

Comment 3 Adam Williamson 2019-03-08 17:11:47 UTC

Same again on another install. Maybe we should fix that one first, then, and worry about this one if it shows up again =)

Comment 4 Eric Garver 2019-03-08 20:24:33 UTC

(In reply to Adam Williamson from comment #3)
> Same again on another install. Maybe we should fix that one first, then, and
> worry about this one if it shows up again =)

See bug 1686660 comment 1.

Comment 5 Adam Williamson 2019-03-08 20:45:16 UTC

Indeed, re-assigning to selinux-policy.

Comment 6 Lukas Vrabec 2019-03-11 17:58:31 UTC

commit f36721500c5e2596fc4157cfab3b88e3b1bda7a8
Author: Lukas Vrabec <lvrabec>
Date:   Mon Mar 11 09:52:56 2019 +0100

    Fix interface modutils_run_kmod() where was used old interface modutils_domtrans_insmod instead of new one modutils_domtrans_kmod()
    Resolves: rhbz#1686660
    Resolves: rhbz#1686654