Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 168905

Summary:	Review Request: python-nltk
Product:	[Fedora] Fedora	Reporter:	Michel Alexandre Salim <michel.salim>
Component:	Package Review	Assignee:	Aurelien Bompard <gauret>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://hircus.org/fedora/python-nltk/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-02-12 11:08:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Michel Alexandre Salim 2005-09-21 04:59:27 UTC

Spec Name or Url: python-nltk.spec
SRPM Name or Url: python-nltk-1.4.4-1.src.rpm
Description: 

The Natural Language Toolkit is a Python package that simplifies the construction of programs that process natural language, and defines standard interfaces between the different components of an NLP system.

Comment 1 Aurelien Bompard 2005-09-26 17:16:05 UTC

This package can't be noarch since it installs files in %{_libdir}, which
becomes /usr/lib64 on x86_64 systems.
I don't see any other problem :)

Comment 2 Toshio Kuratomi 2005-09-27 01:42:04 UTC

I only see py/pyc/pyo in this package which are being installed to /usr/lib even
on x86_64.

$uname -m
x86_64
$ python  -c "from distutils.sysconfig import get_python_lib; print
get_python_lib()"
/usr/lib/python2.4/site-packages

Since this is the definition of python_sitelib which is used in the spec file,
files should either be installed in /usr/lib or it will cause rpmbuild to error out.

Comment 3 Aurelien Bompard 2005-09-27 09:03:44 UTC

Ah, right, I thought %{python_sitelib} was based on %{_libdir}, but obviously it
is not :)
Review for release 1:
* RPM name is OK
* Source nltk-1.4.4.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of python-nltk looks OK
* File list of python-nltk looks OK
* Included demo runs fine.
APPROVED

Comment 4 Aurelien Bompard 2006-02-12 11:08:44 UTC

python-nltk is published, closing bug