Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 168920
| Summary: | Review Request: html-xml-utils | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gavin Henry <ghenry> |
| Component: | Package Review | Assignee: | Brian Pepple <bdpepple> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.w3.org/Tools/HTML-XML-utils/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-10-17 21:22:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Gavin Henry
2005-09-21 10:58:58 UTC
PUBLISH +1, once package naming issue resolved.
MD5Sums:
ffd80f1fda6ecdd1f85bd88d87a0d2e7 html-xml-utils-3.7.tar.gz
Good:
* Source URL is canonical
* Upstream source tarball verified
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All directories are owned by this or other packages
* All necessary BuildRequires listed.
* All desired features are enabled
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners
* Package installs and uninstalls cleanly on FC4
* Software runs fine
Bad:
* Is there any reason why the package name doesn't follow the upstream tarball
name? Based on a quick Google search, every other rpm package I could find
follows the upstream tarball.
Minor:
* The NEWS file shouldn't be packaged, since it's empty.
Did you see the above? --------- Quote: --------- "Created as a Requirement to install db2latex-xsl-0.7-alt2.cvs20030622.noarch.rpm, which requires a xml-utils RPM, which are both needed to run the Samba-Docs build tree, as discussed during Tues Sep 20 Fedora Documentation Steering Committee meeting." That's the only reason I changed the name. Can change it now, as it never worked and will delete NEWS file, once you confirm above. Gavin. Yeah, I did see the snippet about it being a requirement of db2latex-xsl, but it seemed like a case of the tail wagging the dog to me. ;) Yeah, I know. Doesn't matter anymore, so I'll update it this weekend. Gavin. Spec Url: http://www.perl.me.uk/downloads/html-xml-utils/html-xml-utils.spec SRPM Url: http://www.perl.me.uk/downloads/html-xml-utils/html-xml-utils-3.7-2.src.rpm Md5sum Url: http://www.perl.me.uk/downloads/html-xml-utils/md5sums Changed name back to html-xml-utils and removed the empty README Gavin. Package approved. Refer to Review in comment #1. Doh, removed README instead of NEWS. Rebuilding. Spec Url: http://www.perl.me.uk/downloads/html-xml-utils/html-xml-utils.spec SRPM Url: http://www.perl.me.uk/downloads/html-xml-utils/html-xml-utils-3.7-3.src.rpm Md5sum Url: http://www.perl.me.uk/downloads/html-xml-utils/md5sums Gavin, what's the status of this? Has it been built yet? Sorry, I was waiting for your final approve. Committed and built. Gavin. Package published, but bug never closed. |