Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 169092
| Summary: | Review Request: rocksndiamonds: Underground digging game | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
| Component: | Package Review | Assignee: | Brian Pepple <bdpepple> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list, mpeters |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.artsoft.org/rocksndiamonds/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-09-23 16:45:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Tom "spot" Callaway
2005-09-22 21:43:32 UTC
Spot, looks like your missing a BuildRequires for SDL_net-devel.
<snip>
In file included from system.h:30,
from system.c:23:
sdl.h:20:21: error: SDL_net.h: No such file or directory
system.c: In function 'InitPlatformDependentStuff':
system.c:122: warning: implicit declaration of function 'SDLNet_Init'
system.c: In function 'get_cursor_from_image':
system.c:1016: warning: ignoring return value of 'sscanf', declared with
attribute warn_unused_result
system.c:1049: warning: ignoring return value of 'sscanf', declared with
attribute warn_unused_result
make[2]: *** [system.o] Error 1
make[2]: Leaving directory `/builddir/build/BUILD/rocksndiamonds-3.1.1/src/libgame'
make[1]: *** [libgame_dir] Error 2
make[1]: Leaving directory `/builddir/build/BUILD/rocksndiamonds-3.1.1/src'
make: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.93975 (%build)
</snip>
(In reply to comment #1) > Spot, looks like your missing a BuildRequires for SDL_net-devel. Adding that and it builds in mock for me. However - bunch of this from rpmlint: *snip* 3.1.1/elements/timegate_switch.txt W: rocksndiamonds wrong-file-end-of-line-encoding /usr/share/doc/rocksndiamonds-3.1.1/elements/bd_firefly.txt W: rocksndiamonds wrong-file-end-of-line-encoding /usr/share/doc/rocksndiamonds-3.1.1/elements/amoeba_wet.txt W: rocksndiamonds wrong-file-end-of-line-encoding /usr/share/doc/rocksndiamonds-3.1.1/elements/satellite.txt *snip* (In reply to comment #1) > Spot, looks like your missing a BuildRequires for SDL_net-devel. Sure enough, I am. (In reply to comment #2) > However - bunch of this from rpmlint: > > *snip* > 3.1.1/elements/timegate_switch.txt > W: rocksndiamonds wrong-file-end-of-line-encoding I think these are safe to ignore. They're just text descriptor files for the map components. New SRPM: http://www.auroralinux.org/people/spot/review/rocksndiamonds-3.1.1-2.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/rocksndiamonds.spec PUBLISH +1
MD5Sums:
6a6e0397f043314e3df8ee85c03590b5 rocksndiamonds-3.1.1.tar.gz
Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* Desktop entry is fine
* All directories are owned by this or other packages
* All necessary BuildRequires listed.
* All desired features are enabled
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners
* Package installs and uninstalls cleanly on FC4
* Software runs fine
Minor:
* Rpmlint errors: Refer to comment #2
|