Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1692367

Summary: python-smartcols FTBFS with pytest 4.3
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-smartcolsAssignee: Igor Raits <igor.raits>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: igor.raits
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-07-09 14:52:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1671167, 1686977    
Attachments:
Description Flags
build.log from copr
none
root.log from copr none

Description Miro Hrončok 2019-03-25 13:01:03 UTC
Created attachment 1547688 [details]
build.log from copr

With new pytest, the tests of python-smartcols fail with:

/usr/lib/python3.8/site-packages/pluggy/hooks.py:289: in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
/usr/lib/python3.8/site-packages/pluggy/manager.py:68: in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
/usr/lib/python3.8/site-packages/pluggy/manager.py:59: in <lambda>
    self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
/usr/lib/python3.8/site-packages/_pytest/python.py:226: in pytest_pycollect_makeitem
    res = list(collector._genfunctions(name, obj))
/usr/lib/python3.8/site-packages/_pytest/python.py:403: in _genfunctions
    self.ihook.pytest_generate_tests(metafunc=metafunc)
/usr/lib/python3.8/site-packages/pluggy/hooks.py:289: in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
/usr/lib/python3.8/site-packages/pluggy/manager.py:68: in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
/usr/lib/python3.8/site-packages/pluggy/manager.py:59: in <lambda>
    self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
/usr/lib/python3.8/site-packages/_pytest/python.py:133: in pytest_generate_tests
    metafunc.parametrize(*marker.args, **marker.kwargs)
/usr/lib/python3.8/site-packages/_pytest/python.py:990: in parametrize
    argnames, parameters = ParameterSet._for_parametrize(
/usr/lib/python3.8/site-packages/_pytest/mark/structures.py:114: in _for_parametrize
    if len(param.values) != len(argnames):
E   TypeError: object of type 'MarkDecorator' has no len()

This is most likely because the deprecated and now removed support from marking parameters directly with markers.



This is the last bit of previous build log, with the deprecation visible:

arameters is deprecated, please use pytest.param(..., marks=...) instead.
  For more details, see: https://docs.pytest.org/en/latest/parametrize.html
    @pytest.mark.parametrize("name, args", [
-- Docs: https://docs.pytest.org/en/latest/warnings.html
========== 18 passed, 6 xfailed, 3 warnings, 15 error in 1.34 seconds ==========


When this is solved, the previous FTBFS with tests failures need to be solved as well.

Comment 1 Miro Hrončok 2019-03-25 13:02:45 UTC
Created attachment 1547689 [details]
root.log from copr

Comment 4 Miro Hrončok 2019-07-09 14:52:07 UTC
I've merged that PR myself.