Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 169512
Summary: | Review Request: net6 - A TCP protocol abstraction for library C++ | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Luke Macken <lmacken> |
Component: | Package Review | Assignee: | Adrian Reber <adrian> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list, pfrields, scott |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://releases.0x539.de/net6 | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-10-02 22:44:43 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 169513 |
Description
Luke Macken
2005-09-29 06:52:17 UTC
> Requires: libsigc++20
This is usually not necessary as it is picked up automatically by RPM.
The -devel package needs "Requires: pkgconfig, libsigc++20-devel"
You have to use the %find_lang macro
> %description devel
> .. This package contains
> the static library for use of net6.
... This doesn't match reality.
(In reply to comment #1) > > Requires: libsigc++20 > This is usually not necessary as it is picked up automatically by RPM. > > The -devel package needs "Requires: pkgconfig, libsigc++20-devel" > > You have to use the %find_lang macro Done. (In reply to comment #2) > > %description devel > > .. This package contains > > the static library for use of net6. > > ... This doesn't match reality. Meaning the package doesn't contain the static library ? or the description is false somehow ? Suggestions welcome. (In reply to comment #4) > Meaning the package doesn't contain the static library ? Yep. > Suggestions welcome. Just delete the sentence. (In reply to comment #5) > (In reply to comment #4) > > > Meaning the package doesn't contain the static library ? > Yep. > > > Suggestions welcome. > Just delete the sentence. Heh, oops :) Removed static library reference. Could you please update the changelog and the release. If you use the %find_lan macro you have to exclude the .mo files from the %files section and include them with %files -f %{name}.lang Done. http://people.redhat.com/lmacken/net6.spec http://people.redhat.com/lmacken/net6-1.1.0-2.src.rpm Looks pretty good. The only thing now missing is a "Requires: libsigc++20-devel" in the -devel subpackage. (In reply to comment #9) > Looks pretty good. The only thing now missing is a "Requires: libsigc++20-devel" > in the -devel subpackage. Fixed (although if -devel Requires %{name}-%{version} (which requires libsigc++20-devel), is this even necessary?) > Fixed (although if -devel Requires %{name}-%{version} (which requires
> libsigc++20-devel), is this even necessary?)
%{name}-%{version} doesn't require libsigc++20-devel, it is a BuildRequires. As
the header files in the -devel package do include header files from
libsigc++20-devel (and there is also a reference to it in the pkgconfig file) it
is necessary that the -devel package Requires: libsigc++20-devel. That way other
package only have to BuildRequire net6-devel and all necessary Requires are
automatically pulled in, like it should be for example in obby.
* source matches upstream * rpmlint is almost happy * spec looks good * use of find_lang macro * correct Requires and BuildRequires * scriptlets look sane * correct use of -devel subpackage * clean installation and removal APPROVED Please update changelog and release during each review step. Imported into CVS, branches requested for fc-3 and fc-4, and successfully tagged and built devel branch for Fedora Extras. Thanks! |