Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 169513
Summary: | Review Request: obby - A library which provides synced document buffers | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Luke Macken <lmacken> |
Component: | Package Review | Assignee: | Adrian Reber <adrian> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list, pfrields, scott |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://releases.0x539.de/obby | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-10-06 17:21:03 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 169512 | ||
Bug Blocks: | 163779, 169514 |
Description
Luke Macken
2005-09-29 06:53:57 UTC
Added gmp-devel to BuildRequires. After a quick glance at the spec file I can see the same issues as with net6: -devel requires at least pkgconfig use the %find_lang macro Done. http://people.redhat.com/lmacken/obby.spec http://people.redhat.com/lmacken/obby-0.2.0-2.src.rpm -devel subpackage needs to require: net6-devel as the include files from obby-devel include net6 headers files. The BuildRequires libsigc++20-devel is not necessary as this is already required by net6-devel. The rest looks good. Updated. http://people.redhat.com/lmacken/gobby.spec http://people.redhat.com/lmacken/gobby-0.2.2-1.src.rpm Forgot one more thing: the -devel subpackage also requires gmp-devel as it can be seen it buffer.hpp and rsa.hpp By the way: SRPM gives a 404 and the spec file is the SRPM. updated.. links should be good now. http://people.redhat.com/lmacken/gobby.spec http://people.redhat.com/lmacken/gobby-0.2.2-3.src.rpm Per Adrian's comment #2, I'd suggest adding to %install: %find_lang %{name} and to %files: %files -f %{name}.lang instead of hard-coding %{_datadir}/locale/*/LC_MESSAGES/gobby.mo Updating bugzilla summary to match package name/summary. OK, it appears there are 2 packages for Review here (so I got confused): * obby: library * gobby: editor, which BuildRequires: obby-devel For reviewers' sanity, I'd suggest submitting each in its own bugzilla entry. (In reply to comment #11) > OK, it appears there are 2 packages for Review here (so I got confused): > * obby: library > * gobby: editor, which BuildRequires: obby-devel > > For reviewers' sanity, I'd suggest submitting each in its own bugzilla entry. Obby: This bug Gobby: Bug #169514 I'm to blame for this confusion seeing as I pasted links to gobby spec/srpm starting in comment #5; all of the review in this bug is for the obby library. Latest spec/srpm: http://people.redhat.com/lmacken/obby-0.2.0-3.src.rpm http://people.redhat.com/lmacken/obby.spec Sorry for the confusion guys. * builds in mock * rpmlint is happy * correct usage of -devel * spec looks good * clean installation and removal * use of find_lang macro * correct Requires and BuildRequires * scriptlets look sane APPROVED * Imported into cvs * Added to owners.list * Requested FC3/FC4 branches * Build sucessfully in devel branch Thanks! You could add --with-howl to configure and the BR howl-devel to the spec for FC-4 and greater. Built howl support into the devel branch. Will add it to FC4 shortly after. |