Bug 169753

Needs work.

%prep fails at autoreconf, you'll need autoconf as a BuildRequires

You will need to register the tclhttpd user. 
http://fedoraproject.org/wiki/PackageUserCreation

Created attachment 121279 [details]
rpmlint ouptut

I tried adding an entry for the tclhttpd user on
http://fedoraproject.org/wiki/PackageUserRegistry, but I don't have edit
permission on that page.

New spec file is available at:
http://www.kobold.org/~wart/fedora/tclhttpd.spec

This spec file cleans addresses the problems mentioned above, and cleans up some
of the rpmlint warnings.

I think that the rest of the remaining rpmlint warnings can be ignored for the
following reasons (feel free to disagree and/or suggest workarounds):

E: tclhttpd non-standard-uid /etc/tclhttpd tclhttpd
E: tclhttpd non-standard-gid /etc/tclhttpd tclhttpd
    - Yes, it is a non-standard uid.  This is a new uid created by
      the package so that the tclhttpd server doesn't have to run as
      root.
W: tclhttpd hidden-file-or-dir /var/www/tclhttpd/htdocs/status/.tclaccess
    - Yes, these are hidden by design.  The .tclaccess files are the
      tclhttpd equivalent of .htaccess files, except that they use
      tcl code for access control instead of standard .htaccess syntax.
W: tclhttpd hidden-file-or-dir /var/www/tclhttpd/htdocs/templates/.tml
    - These are also hidden by design.  .tml files are library template files
      that are loaded for all tcl application scripts in the current directory.
E: tclhttpd htaccess-file /var/www/tclhttpd/htdocs/htaccess/.htaccess
    - This is not apache, but it allows the use of .htaccess files for
      access control.  This error only pertains to apache .htaccess files.
E: tclhttpd executable-marked-as-config-file
/var/www/tclhttpd/htdocs/cgi-bin/wiki.cgi
    - The tclhttpd content directory /var/www/tclhttpd contains a default
      wwwroot that can be customized.  Since these files can be customized
      after installation, they must not be replaced during an upgrade,
      thus, they are marked as %config(noreplace).  This also includes
      a few cgi scripts which are triggering this error.
E: tclhttpd zero-length /var/www/tclhttpd/htdocs/empty.html
    - Intentionally empty file used for web page layouts.
E: tclhttpd script-without-shellbang /usr/bin/httpdthread.tcl
    - This isn't really meant to be invoked directly, but is instead
      sourced by the real startup script /usr/bin/tclhttpd.
W: tclhttpd log-files-without-logrotate /var/log/tclhttpd
    - tclhttpd has its own builtin log rotation system.
W: tclhttpd dangerous-command-in-%preun rm
W: tclhttpd dangerous-command-in-%postun rm
    - Any better suggestions on how to get rid of these runtime files?  I'm
      inclined to ignore this.

(In reply to comment #3) 
> E: tclhttpd script-without-shellbang /usr/bin/httpdthread.tcl 
>     - This isn't really meant to be invoked directly, but is instead 
>       sourced by the real startup script /usr/bin/tclhttpd. 
 
That sounds to me like the script should not be executable, and not installed 
in /usr/bin. 

Good point about httpdthread.tcl.  I've moved it to /usr/share/tclhttpd3.5.1. 
New files can be found at:

http://www.kobold.org/~wart/fedora/tclhttpd.spec
http://www.kobold.org/~wart/fedora/tclhttpd-3.5.1-5.src.rpm
http://www.kobold.org/~wart/fedora/MD5SUM.asc

(In reply to comment #3)
> I tried adding an entry for the tclhttpd user on
> http://fedoraproject.org/wiki/PackageUserRegistry, but I don't have edit
> permission on that page.
> 

What's your wiki name so I can add you to the EditGroup ?

(In reply to comment #6)
> (In reply to comment #3)
> > I tried adding an entry for the tclhttpd user on
> > http://fedoraproject.org/wiki/PackageUserRegistry, but I don't have edit
> > permission on that page.
> > 
> 
> What's your wiki name so I can add you to the EditGroup ?

MichaelThomas

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #3)
> > > I tried adding an entry for the tclhttpd user on
> > > http://fedoraproject.org/wiki/PackageUserRegistry, but I don't have edit
> > > permission on that page.
> > > 
> > 
> > What's your wiki name so I can add you to the EditGroup ?
> 
> MichaelThomas

Added.

(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > (In reply to comment #3)
> > > > I tried adding an entry for the tclhttpd user on
> > > > http://fedoraproject.org/wiki/PackageUserRegistry, but I don't have edit
> > > > permission on that page.
> > > > 
> > > 
> > > What's your wiki name so I can add you to the EditGroup ?
> > 
> > MichaelThomas
> 
> Added.


...and Added.  to the PackageUserRegistry, that is.

- package meets naming guidelines
- package meets packaging guidelines
- license (BSD) OK, text in %doc
- spec file legible, well commented
- source matches upstream
- package compiles and runs on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- no duplicate files (man page does not conflict with httpd either)
- %clean ok
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 
- tclhttpd uid/gid registered
- chkconfig compatible init script

Macro use isn't entirely consistent, tclhttpd in some places and %{name} others,
but not a blocker

rpmlint still complains about tclhttpd user and group, .htaccess files, and
hidden .tclaccess files, but these can be ignored for the reasons described in
comment 3

APPROVED